From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753119AbdLENvd (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 08:51:33 -0500
Received: from mga14.intel.com ([192.55.52.115]:52348 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752376AbdLENv3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 08:51:29 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,364,1508828400"; 
   d="scan'208";a="13278018"
Subject: Re: [patch 55/60] x86/mm: Use INVPCID for __native_flush_tlb_single()
To: Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>
References: <20171204140706.296109558@linutronix.de>
 <20171204150609.338279526@linutronix.de>
 <CALCETrVTusvLtikp13JT1LcfJ0BJxDYmv5TVzh3Pa43u_HdhxA@mail.gmail.com>
 <20171204225144.GD20227@worktop.programming.kicks-ass.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bpetkov@suse.de>,
        Greg KH <gregkh@linuxfoundation.org>, Kees Cook <keescook@google.com>,
        Hugh Dickins <hughd@google.com>, Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Rik van Riel <riel@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        David Laight <David.Laight@aculab.com>,
        Eduardo Valentin <eduval@amazon.com>, aliguori@amazon.com,
        Will Deacon <will.deacon@arm.com>,
        Daniel Gruss <daniel.gruss@iaik.tugraz.at>,
        Dave Hansen <dave.hansen@linux.intel.com>
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <c52b6ad1-f9f0-d286-ef00-399927e4f570@intel.com>
Date: Tue, 5 Dec 2017 05:51:28 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171204225144.GD20227@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/04/2017 02:51 PM, Peter Zijlstra wrote:
> We should find some of the benchmarks that were used to determine
> tlb_single_page_flush_ceiling and measure. I've not gotten around to
> doing either.
> 
> Someone called Dave Hansen did that patch and might still have something
> lying around to help with that:
> 
>   a5102476a24b ("x86/mm: Set TLB flush tunable to sane value (33)")

I hate git. :)

But, yeah, we have certainly changed enough variables to necessitate
measuring it again.