Re: [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages

["Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>]

On 23/08/2023 15:25, Matsuda, Daisuke/松田 大輔 wrote:
> On Wed, Aug 23, 2023 4:17 PM Li, Zhijian wrote:
>>
>> On 23/08/2023 15:07, Matsuda, Daisuke/松田 大輔 wrote:
>>> On Wed, Aug 23, 2023 3:12 PM Li Zhijian wrote:
>>>>
>>>> Previously rxe_{dbg,info,err}() macros are appened built-in newline,
>>>> sut some users will add redundent newline some times. So remove the
>>>> built-int newline for this macros.
>>>
>>> It seems the sentences above contain 4 typos.
>>> Perhaps, you can use a spell checker. (MS Outlook will do.)
>>>
>>
>> hahaha， My Thunderbird spell checker only found out "appened" "sut" and redundent
>> where is the 4th one :)
> 
> 'built-int' at the 3rd line.
> 
>>
>>
>>
>>>>
>>>> In terms of rxe_{dbg,info,err}_xxx() macros, because they don't have
>>>> built-in newline, append newline when using them.
>>>>
>>>> CC: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
>>>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>>>> ---
>>>
>>> Great!
>>> I am afraid there are still 4 massages to fix.
>>> Can you check rxe_init_sq() and rxe_init_rq() in rxe_qp.c?
>>
>> rxe_init_sq() and rxe_init_rq() has gone in my v6.5-rc7 ? Didn't you
> 
> I see. My check was based on v6.5-rc1 (jgg-for-next).

You inspire me, i should make this patch on rdma/for-next.



> I confirmed they are gone in jgg-for-rc. Looks good.
> 
> Daisuke
> 
>>
>>
>>
>>
>>>
>>> Feel free to add my reviewed-by tag in next revision:
>>> Reviewed-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
>>
>> thanks
>>
>>>
>>> Daisuke
>>>
>>>>    I have use below script to verify if all of them are cleanup:
>>>>    git grep -n -E "rxe_info.*\"|rxe_err.*\"|rxe_dbg.*\"" drivers/infiniband/sw/rxe/ | grep -v '\\n'
>>>> ---
>>>>    drivers/infiniband/sw/rxe/rxe.c       |   6 +-
>>>>    drivers/infiniband/sw/rxe/rxe.h       |   6 +-
>>>>    drivers/infiniband/sw/rxe/rxe_comp.c  |   4 +-
>>>>    drivers/infiniband/sw/rxe/rxe_cq.c    |   4 +-
>>>>    drivers/infiniband/sw/rxe/rxe_mr.c    |  16 +-
>>>>    drivers/infiniband/sw/rxe/rxe_mw.c    |   2 +-
>>>>    drivers/infiniband/sw/rxe/rxe_resp.c  |  12 +-
>>>>    drivers/infiniband/sw/rxe/rxe_task.c  |   4 +-
>>>>    drivers/infiniband/sw/rxe/rxe_verbs.c | 216 +++++++++++++-------------
>>>>    9 files changed, 135 insertions(+), 135 deletions(-)