From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DA047ECD3 for ; Fri, 5 Jun 2026 07:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645622; cv=none; b=UtyPp3JTprvhc/kAuPVwgW5NJNuwlzZVZNl6GwxZDBH6hYTu4WQAhQg0kQMiVcTu7+t95u2V02zrthGyr5Qfi7GO9ZoJzrZfp8iS5AIi2Ib2XjmElwRx5+Yty1AAn87zKy/oW4q6FzdQAmhJ9+7mUyhgMLp8v7S9PL6+FFtoImI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780645622; c=relaxed/simple; bh=YmUCBab2PB7a1Ft4+8MUszAWy7h4DNcu3/1kIXnZQhA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WasjlY0CAmwUccTaxecsM4YpHAv+l4VqQnun65/C429iV3Rpt4oCVvfQe+uUdkGZ4+Z4X6WxhTS/n83F2okEPYyVeARGhC3XtatGpJic21xe74lI9bIgJoemXUCyOWGtIk8AA/iiHIqi0lwxqpC5ybKfR1cLYYYRvJ2kzIGsroM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NOk328+N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iNqzFBgS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NOk328+N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iNqzFBgS" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6555q8uW2427821 for ; Fri, 5 Jun 2026 07:47:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zy7UIGAcdB7bApBTj2vxSF+W7ahUfjS+snn+WWc6QaU=; b=NOk328+NlAVTyI2F CSFMFSJO6kvlqTAOtAdBeKiTDbtc3gBFweJ06DwjWa9SyPdLBqCrORdVLqjCyTGj XOjjmFYRR/rgZI+s0uxuTbafHUpKOg23IjQfOoVApJ6MTGjkKNMZMROKKAlVqHPk 2ZJ3dUi8srA4iW0s9FNmiKgal/MHyg+f7ztyhjFGrZfQ/xvzq1RwQilb40b3fZG7 +sn2wdEvz2p0nMz6siEKS7yxI32i2BMvlZ0tymykeLRCht8o/pZB4aiNEBll5A/O loLjToEISS2ABoLbwPKnx4BnhFZuPGs2qtCyX8p6cKugBBnj4enK0cQBzpFIw7Tz ug9uUw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ekrphgdqv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Jun 2026 07:46:59 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c0c1e112dfso24265615ad.0 for ; Fri, 05 Jun 2026 00:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780645619; x=1781250419; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zy7UIGAcdB7bApBTj2vxSF+W7ahUfjS+snn+WWc6QaU=; b=iNqzFBgSvWLV6gC+89Mb8rCwwsQm/x71n8Njj608IjbaxB/36k9URleC1+E/i0LIhQ QklyppSblu9uopXcBqgX21jzex519o7q+JinK2u2DvK7KUcOw/0JXz4PC2Vu81m7rO7B EU4Fbzp05vKNVRsDwA3qLscS+fTVJUtDGs+TtTUPhHcHwgu6ORxDL5kpUzDm/HRw4RWe NxvfUPiy1G5Y3eB/Kl42BRx73je9cimKjspAjQVyH+B5L/vSiZcDQoHWrWEDwn47Wsht tHYRN+2+uiirQh3NojTivebQa+F3YhNFbJOR9h5MQnE+dIevHU4ATpg9m7IV55USils8 UCcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780645619; x=1781250419; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zy7UIGAcdB7bApBTj2vxSF+W7ahUfjS+snn+WWc6QaU=; b=Yf2dDSg50Rtwcnc8xObRZPJRu7YVz4+r4kZ2k+od82tdssScZL6WtzIdh21S3FNvmV jAyTNGLMCArRqQQdkPBEopVGCu3RQk348uBkoDnCmIDVr1rL/BTNswVKOhIMfkWKOBr3 H9R5od1eKysY9kLGS2ExFKHjPhcvaxbAUBZHluV/Yb/6P27AYkHDjX8NoiOBbwhof0rY mrgJGAS2D1yATmjfYOwZB895DfCeRp15S3yG/nMH6dAxdusSILJYsCMW9wcO8Yvn6tmB AgW6H7MWeDCVeQazaM/w9RlU0L9wl1qs5XDfzyJ+HKmf25GkuVUaSoD+eDkr7W4e65WP +e9A== X-Forwarded-Encrypted: i=1; AFNElJ+3z3leV+6+mWTe2hNdmkLmoWkWfr0ORoRyviQ97/+IDJpfC3Xq9yHsfo8Tnb/MKM+l3+sqThoSd8/FZ6M=@vger.kernel.org X-Gm-Message-State: AOJu0YxzuHJjQX5g8rlPunVZ1X1LqNeP+EmbEWmbzldSqBgbtc6odMDZ DZbAvP7JFElTVBoDWJP4QCk8NuZuEDYhMGqzQ8ZcTXtThmryTGmcpV5MaBWTgDjKiyxw1LhQ6Su S21PMeDGVxOLM9g2rtF3EGaEDDLHcoGNbirQxz6BWvBG4tjXWaI4eQYqI59F5H3yz+AI= X-Gm-Gg: Acq92OGwjn8JsJiN8kv84NfKPo06tMYUUBkiActYZY64VBZbpDcSvL7aRjtM/R3y6fl KkJRBVSEdttrD3/HR4+CkzreY/p+T9IKvFU/K2vkZ1MoW2pu04+T0Yjq5qDaYWEZnSVk3vOrgfP ZiEnwL7RVsvkiMQDSY0O8uh0mEwbGm64V9DKCFo+f7zhxqL+8wHCt2ePuEZuF8VFTiblbv9cFcJ rnFMi7QPnnzYa1Lp3lcHi2x8n/ZszwIjHfewgXVQW2tLu3Awu3Dtx8XBZnxbd8DRpbQnMaeZ6xb h3KA7CocbaJN4BpDYurKdGkJ9N9hHyFIXu6p/hvxxPte4MVCrtVt5X8ams94h/iJzBNoyvr0evw PikzmUVq3/z6nJikA9hHIUJeciIzU+o6CqG2TeEHT/LC5qyuenQ+6sa/3aQ== X-Received: by 2002:a17:903:24d:b0:2bf:e5c:d90b with SMTP id d9443c01a7336-2c1e8338ac3mr23644165ad.32.1780645619311; Fri, 05 Jun 2026 00:46:59 -0700 (PDT) X-Received: by 2002:a17:903:24d:b0:2bf:e5c:d90b with SMTP id d9443c01a7336-2c1e8338ac3mr23643805ad.32.1780645618803; Fri, 05 Jun 2026 00:46:58 -0700 (PDT) Received: from [10.239.155.28] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f88473sm91340025ad.25.2026.06.05.00.46.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 00:46:58 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 15:46:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses() To: Jie Gan , linux-arm-msm@vger.kernel.org, Stephen Boyd , Neil Armstrong , Abel Vesa , Greg Kroah-Hartman Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org References: <20260604-spmi-bus-register-fix-v1-1-136adda83a92@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: gExYiG4f7vpKtGzyq9gYc2Qm1YnkH7ew X-Proofpoint-GUID: gExYiG4f7vpKtGzyq9gYc2Qm1YnkH7ew X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA3NCBTYWx0ZWRfXxNOrWnvh6qFA cNDtz95Gi7sQ80wHqjGnQ51yY9J+WsZR9LtuBnpZu7SoJifWBAAeJIyF4hTOZZWL8hBFKt4y3Ic FYDfsAf50YRCgUgDC7ovrGhrH/jMcW5GamIjnW/ky8/M7okjdrEDZppb7GaQjHbSdVQOB8P4kCk bCNadnvBIWac21LLuU2zKIkp0D3+aioGzu2onlnTAiLodb2hQkszuqa2/mi63H+xVP1MALJS18t oFvBKy8XGQ2GuNLDRdZ0imkgv8txRrZnctQkqAbyF8pN53Lz/TT6tiPWEJTThLmJiXItAkcjcNE EKY/r5PJVjFj7627re2qXAHuFDrkD1VZukcpNYlSHO4wI1OCS3+ZXQ43K6YSpu7tUygGgPzF9bE 6hmmhSGc8fM/41Hty9v6R0OO92UnDX0DCrOixkcaWIk//Fm75LhyPhCo+rfmUu5n8ormcOdOdQb s7e1m7fCwt8lmVXfUnw== X-Authority-Analysis: v=2.4 cv=T9a8ifKQ c=1 sm=1 tr=0 ts=6a227ef4 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=61nUwns-zGUAMgZhLmcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-05_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606050074 On 6/5/2026 2:15 PM, Jie Gan wrote: > > > On 6/5/2026 1:46 PM, Fenglin Wu wrote: >> Call of_node_put(child) to reduce its reference count when >> bailing out from the for_each_available_child_of_node() loop >> upon an error in bus registration. >> >> Also, return 0 directly if there are no errors in bus >> registration. >> >> Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support") >> Signed-off-by: Fenglin Wu >> --- >>   drivers/spmi/spmi-pmic-arb.c | 6 ++++-- >>   1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c >> index 2e2cb4774103..26e804ad95a1 100644 >> --- a/drivers/spmi/spmi-pmic-arb.c >> +++ b/drivers/spmi/spmi-pmic-arb.c >> @@ -2055,12 +2055,14 @@ static int >> spmi_pmic_arb_register_buses(struct spmi_pmic_arb *pmic_arb, >>       for_each_available_child_of_node_scoped(node, child) { >>           if (of_node_name_eq(child, "spmi")) { >>               ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb); >> -            if (ret) >> +            if (ret) { >> +                of_node_put(child); > > We dont need of_node_put here. The > for_each_available_child_of_node_scoped will handle the refcnt > automatically. > > Thanks, > Jie Ahh, thanks for pointing out. Just trying to send a patch which was applied in our downstream code base. I didn't notice this was fixed on the tip. Anyway, still need to fix the minor one on the "ret" value initialization. Will resend. > >>                   return ret; >> +            } >>           } >>       } >>   -    return ret; >> +    return 0; >>   } >>     static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb >> *pmic_arb) >> >> --- >> base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a >> change-id: 20260604-spmi-bus-register-fix-dfdb94bf834e >> >> Best regards, >> -- >> Fenglin Wu >> >