From: Johannes Berg <johannes@sipsolutions.net>
To: James Guan <guan_yufei@163.com>
Cc: kuba@kernel.org, kuniyu@google.com, shaw.leon@gmail.com,
kees@kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: Fix page fault in __cfg80211_connect_result()
Date: Tue, 09 Sep 2025 14:00:59 +0200 [thread overview]
Message-ID: <c536fa6aa022e50fb849b84cc33443ade7f53930.camel@sipsolutions.net> (raw)
In-Reply-To: <20250909063213.1055024-1-guan_yufei@163.com>
On Tue, 2025-09-09 at 14:32 +0800, James Guan wrote:
> When I attempted to connect to a virt_wifi device using iw on 6.17-rc5,
> a page fault occurred in __cfg80211_connect_result(), preventing successful
> connection.
>
> The page fault is triggered because virt_wifi_connect_complete() sets
> requested_bss to NULL when no BSSID is specified.
>
> This patch fixes the bug by adding a check for a NULL connected_addr
> before calling ether_addr_copy() in __cfg80211_connect_result().
That might fix the bug, but it makes no sense to have a connection
without an address of the AP that you connected to ...
johannes
prev parent reply other threads:[~2025-09-09 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 6:32 James Guan
2025-09-09 12:00 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c536fa6aa022e50fb849b84cc33443ade7f53930.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=guan_yufei@163.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shaw.leon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®