From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753272AbdBNQOn (ORCPT ); Tue, 14 Feb 2017 11:14:43 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:40342 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751356AbdBNQOf (ORCPT ); Tue, 14 Feb 2017 11:14:35 -0500 Subject: Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests To: Michael Ellerman , bamvor.zhangjian@huawei.com References: <1486630590-9410-1-git-send-email-mpe@ellerman.id.au> <87shnhmsl1.fsf@concordia.ellerman.id.au> Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org From: Shuah Khan Message-ID: Date: Tue, 14 Feb 2017 09:14:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <87shnhmsl1.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 07:09 PM, Michael Ellerman wrote: > Michael Ellerman writes: > >> In commit 88baa78d1f31 ("selftests: remove duplicated all and clean >> target"), the "all" target was removed from individual Makefiles and >> added to lib.mk. >> >> However the "all" target was added to lib.mk *after* the existing >> "runtests" target. This means "runtests" becomes the first (default) >> target for most of our Makefiles. > ... >> >> Fix it by moving the "all" target to the start of lib.mk, making it the >> default target. >> >> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target") >> Signed-off-by: Michael Ellerman > > Hi Shuah, > > Can you please merge this series into linux-next? > > The selftests are badly broken otherwise. > > cheers > Hi Michael, Thanks. All 5 patches are now in linux-kselftest next with Tested-by tag from Bamvor for 1,2,3. thank you both, -- Shuah