RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files

["Ding, Shenghao" <shenghao-ding@ti.com>]

Hi Brown
Thanks for your comment. Feedback is inline.
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, July 2, 2024 1:06 AM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com;
> perex@perex.cz; pierre-louis.bossart@linux.intel.com;
> 13916275206@139.com; zhourui@huaqin.com; alsa-devel@alsa-project.org;
> Salazar, Ivan <i-salazar@ti.com>; linux-kernel@vger.kernel.org; Chadha,
> Jasjot Singh <j-chadha@ti.com>; liam.r.girdwood@intel.com; Yue, Jaden
> <jaden-yue@ti.com>; yung-chuan.liao@linux.intel.com; Rao, Dipa
> <dipa@ti.com>; yuhsuan@google.com; Lo, Henry <henry.lo@ti.com>;
> tiwai@suse.de; Xu, Baojun <baojun.xu@ti.com>; soyer@irl.hu;
> Baojun.Xu@fpt.com; judyhsiao@google.com; Navada Kanyana, Mukund
> <navada@ti.com>; cujomalainey@google.com; Kutty, Aanya
> <aanya@ti.com>; Mahmud, Nayeem <nayeem.mahmud@ti.com>;
> savyasanchi.shukla@netradyne.com; flaviopr@microsoft.com; Ji, Jesse
> <jesse-ji@ti.com>; darren.ye@mediatek.com
> Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as
> the prefix name of DSP firmwares and calibrated data files
> 
> On Mon, Jul 01, 2024 at 02:00:13PM +0000, Ding, Shenghao wrote:
> 
> > > I'll apply this but I do wonder if it's worth falling back to trying
> > > to load the unprefixed name if we fail to load the prefixed one.
> 
> > If fail to load dsp firmware, the driver won't load unprefixed name
> > firmware, but switch tas2563/tas2781 to bypass-dsp mode automatically.
> > In this mode, smartamp become simple amp.
> > These day, I met a case from one of my customers, they put 2 pieces of
> > tas2563, and 2 pieces of tas2781 in the same i2c bus. In order to
> > identify tas2563 and tas2781, I think name_prefix is a good solution for this
> case.
> > Looking forward to your comment. Thanks.
> 
> Yes, the name_prefix is a good idea and probably people want things
> specifically tuned for the DSP - I was thinking about error handling or
> upgrade cases where wrong calibration might work better.  Bypass mode
> means the device will still function at least.
In bypass mode, tas2563/tas2781 can still work without speaker protection or audio acoustic function.
In case of only dsp firnmware loading without calibrated data, tas2563/tas2781 still can work with
default calibrated data and default audio acoustic parameter.