From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793827169; b=z1o6wpVQYKd+BUL5N71Mojxu49kgqvZIe9YEmaK0cnTgLf7gnBtBQA6z6m72N17pZZXQ 6qeHsDsVQivQsF8bGgvK2CFAJ9KjXEqb6QCrcE1VcB1vix5hswkF3ZJA6+MMsTRXNsdiA sJqgwdFfu+4gwOXX+1UWq4B9+TJySAMl0+rByjpbPx9n1v22PwWeQeyjNrR8xBFBdn80D 9Jds3kG8SGgHfn5TYWF0Gew96e2GZhGbsXzClbVTC8AIei9fJIHTGt1cAY2Hyy2jVnQ8Y 7tVr2c+inU+me5JKJidxGApsJ3mesB197td9P/B67yoIjapRLFD6808RRgdq1Vv99Ig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793827169; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=3DpEQ4BV8ncjuBOzZJCc6LJDmuPNTxkR4oFZHyN7ZmM=; b=AA0DWok3Fv5LH2ZOv1amCpOM08EE90YjkmBiOJCsz09FxM6UbxMC8hGq0ej3wMNJyfPT h/XeMRQJilMjSvQTT4zHDGOuFyb2X0THQme9fisLI9ybhS/UnGBlXvhgLWhO/nMwvJvZn sYjmRENnq1GtKuYtPOdgJ91hXLMcNoTXTBeD5JJnTaxV5gaySw/hXu6CGxLneSL3TfOmr lLndHU/K6iesfuydRNqkwT9pOiey1gQamar1ofzE450px2GHFFvgurZVq80AEi5b6/MQQ 7CoJXJbgIfk3ti4z2/xvCe8orC0DNBeugpP0IO8XV8PYGHHj8eRL4YMOKSVnzLn2HhA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass header.d=packett.cool header.i=@packett.cool header.a=rsa-sha256 header.s=key1 header.b=jNvCIdSw; arc=none smtp.remote-ip=95.215.58.12 Received: from mta1.migadu.com (out-12.mta1.migadu.com [95.215.58.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1666074F99 for ; Wed, 4 Nov 2026 21:19:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BE1666074F99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=packett.cool header.i=@packett.cool header.a=rsa-sha256 header.s=key1 header.b=jNvCIdSw X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=h8kZr+2P5FyKEJmL9Drkm4bpXOy70o/S/a6qT+o6Brk=; c=simple/simple; d=packett.cool; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793827165; v=1; x=1794431965; b=jNvCIdSwx8XbP6Z/yh4PauQlvjl2yBv9KSsBzTA8ni3TJC+OI+iwREUiak5pSkhymMK8zDB6 AwCAdorhppQ4hJWw8PNnXwolKNXcKo3AOKrNT7oXkc9w6rwXN5vkQ6889UpJo4l0LQ4x+f80RfI JBhmZuvtUWJJYLP9rNGRD9pqEh+mvbY62A2waA//loj/jd+jOR6m33ZOeVUerY33QO5cpXxG9J8 YFjB5WO5gfu0/3+gWEGDp72EXkBj+SfhErYhS0i4yyWtHScgjFkPSdJLl6ip5eY//j7HGsIXTY6 V5unKt6xyV7Fr8/bWxW9I1fdH3KEl5VkFNeNLKzN3SQHQ== X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id c5aecda40ac6f06c; Wed, 04 Nov 2026 21:19:25 +0000 X-Mizu-Trace-ID: c5aecda40ac6f06c X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 4 Nov 2026 18:19:13 -0300 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] media: qcom: camss: Add support for SM8150 To: mail@andrewgigena.dev, Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20261104-sm8150-v7-4-rc1-camss-v1-0-7a9534a9a22f@andrewgigena.dev> <20261104-sm8150-v7-4-rc1-camss-v1-3-7a9534a9a22f@andrewgigena.dev> Content-Language: en-US From: Val Packett In-Reply-To: <20261104-sm8150-v7-4-rc1-camss-v1-3-7a9534a9a22f@andrewgigena.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 11/4/26 5:54 PM, Andrew Gigena via B4 Relay wrote: > From: Andrew Gigena > > Add CAMSS platform data for the Qualcomm SM8150 SoC. The camera > subsystem contains four CSIPHY, four CSID (two full and two lite), two > VFE and two VFE-Lite instances. > > The hardware reuses the existing 3-phase 1.0 CSIPHY, Gen2 CSID and > VFE 17x implementations; the CSIPHY uses the SC8280XP lane register > layout. Add CAMSS_8150 to the version enum and to the shared code > paths, then add the per-block clock, regulator, power domain, > interrupt and interconnect resources. > > Signed-off-by: Andrew Gigena > --- Wow, what an unbelievable coincidence — I just went looking for this and found these patches on gitlab in order to test on the similar sc8180x, and half an hour later you've submitted it to the lists! :D > .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 + > drivers/media/platform/qcom/camss/camss-vfe.c | 2 + > drivers/media/platform/qcom/camss/camss.c | 262 +++++++++++++++++++++ > drivers/media/platform/qcom/camss/camss.h | 1 + > 4 files changed, 267 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index dac8d2ecf799..851decb0691e 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -1141,6 +1141,7 @@ static bool csiphy_is_gen2(u32 version) > case CAMSS_8650: > case CAMSS_8775P: > case CAMSS_X1E80100: > + case CAMSS_8150: It should probably go higher in the sort order, before 8250? > ret = true; > break; > } > @@ -1236,6 +1237,7 @@ static int csiphy_init(struct csiphy_device *csiphy) > regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8250); > break; > case CAMSS_8280XP: > + case CAMSS_8150: > regs->lane_regs = &lane_regs_sc8280xp[0]; > regs->lane_array_size = ARRAY_SIZE(lane_regs_sc8280xp); > break; Interesting, why do these match 8280xp and not, say, 8250? > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index 2680a9914765..dd28058e98a7 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -354,6 +354,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code, > case CAMSS_8650: > case CAMSS_8775P: > case CAMSS_X1E80100: > + case CAMSS_8150: Sort order here too > switch (sink_code) { > case MEDIA_BUS_FMT_YUYV8_1X16: > { > @@ -2010,6 +2011,7 @@ static int vfe_bpl_align_rdi(struct vfe_device *vfe) > case CAMSS_8280XP: > case CAMSS_8300: > case CAMSS_845: > + case CAMSS_8150: > case CAMSS_8550: > case CAMSS_8650: > case CAMSS_8775P: > [..] Thanks, ~val