From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ADD6328611 for ; Fri, 3 Jul 2026 19:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783106116; cv=none; b=QndLMh29c5j4e8OFNW68dDJEcwDh/zF+cnufVbq6bhryDHajRP++8WCWFNq8XCFh+GiwkkPxJPlO5NAKRMQQeId/b4etOv6G/8gAFiSual1EHX5ORU/IE6OJYhQ4dsZZdMJykcC6yetk2x/dHK1IaExbtAj6y9XBxu+KwGX5+1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783106116; c=relaxed/simple; bh=L9p9Y4VXzxuekZP/EEZ0z7wzuiFIMpYE6a3TZYZUhac=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IoHIUhdje00vKQ61ljlKRb7P+l8DxPRYsSH8KNyufc89pZuYD34T98D2nSo/kromJ1t+Ecyhdtqfkh5Ens/FDI4AjLEA5JsFdG9vPedNWIHmiNXIkgsRfX3/BULMpB/Z1nGxlZK+JCUW6NJodzonuaQP0VzkB1tLm6lyBY0qZdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T6KfzN2e; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T6KfzN2e" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5aebf9a509eso914353e87.3 for ; Fri, 03 Jul 2026 12:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783106112; x=1783710912; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GacK7qnd6Vmm65ky3QjmKHqAzlgQEODDT7V52bQINNE=; b=T6KfzN2e+hAuereRlquz7d3O3o1bccxkq0WrV+v3fB5Me19bgAuSwHvaZyrrYj/kbb Yz9rKY1aBmsMbiUdg06QdbJN8w/4Ldz5ngGXY5+7iowt4WyBSTcWy0Q/Z/I5uW6gJPag iTJkdf2+Yb9Pov5dbk/r9wrhn1w6cnXqW6qRo0q/bTGkorgmsn3f423hVNil/C2lF9XY iktdkAK+ZKckDRr1ONt6jEaSbTFu38m1C6tsyvuzXTTTC9BRdt4bQgviaoXv5fNxbtyd M3tuPwd/qXHAWJi8ORXIS+PnxoAQcioGuhvY8mc3+N2WOlZ5jYP9iXprLWyGU+Gqhs3H 6ikQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783106112; x=1783710912; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GacK7qnd6Vmm65ky3QjmKHqAzlgQEODDT7V52bQINNE=; b=d2qewBIUwBbKMmem/U2SEPgdhNk4Xm2YrT23VM4In2k7cW8Pj/OyS4vOiKCOdD50ti rxUPXSJDcsx4DSbb1wy8QlMD7h/EE+oyKpXmiXo1j6e2WT9rQYCkUvc63CMiJ7sS9oL4 NqvO26xQccbVY0k7qGVQJuJ86LZwgOk95AohLcwwrpNK4l4G+SyfS//HaHjQl2vOkmos GkBTUj8ZRoWpn9EylkC/vIxfSZck0FX5+wtMR9dJfX7E+zaVd+DP4r3Orq81UOgeovH/ YV6sL3fbDs/672ECyQ32izZJGdzxH4YSzPAfFgVwvkM3E9yCUN9MnKYtecPCQtYcLMoR ghWw== X-Forwarded-Encrypted: i=1; AHgh+RrhaQMGXrZlyVaUOa8VME+5YXrB8WQAPEohiu1RE72jey8akSWLImwoqV/gHgQCc4Gzhypzpt3xxsnAmTg=@vger.kernel.org X-Gm-Message-State: AOJu0YzeHpzy0pIlreaxCIr0TqmntpyAn6Y8hs+p8zNss+ZJi90NrQIx ZqzszIXCeGxxA4O6ZuShSL7cpdMMeZe7SGflfgq0sDT/w08FnAabJ692 X-Gm-Gg: AfdE7cmYKK5twCBvbWX+rQQSRa7zLKwOH2z5wQcBiVOQJFkFAo6UjQqJp5/flcHuyoD vKoF5QiDzKaQUm4LAQ7oYXiOpNK4r+ZBB9YZD+RP2it4dB4bb8m1kchVTFj1dtxZt1R8+3t0/J5 GqEliQp2lo4SvpcOokVzbUvkdd3DCKCRbVIHfhZXiOeLFFmz6T6bM+DA9RE840s3jQOYTraBAkp hJIers3Bn8r+f64n2gEH8A3ChRPeVmE//YkHeitZ0E6HIqlBWnAuOl/CDh6ndAAkQQUmIqWuuUB CWhsyZjvFCu9C/2T6sNy8tasQIgwYUiSvZPmj4Cj/nJNfqeiYNcvTypoi4FP2Y2+emjuiEjL1sb f152EzonJruxXw/eeZWrkDoMHueDPJZC7hcg5F28/jiVrILMk+ssOScAzLLcVmXjGOK1vEwwKRZ eH1gSO0ip4DcJGSiQMX0SH0x3hl7MrJb14Ju4dRLN7C8EixV6RIuwPq6MCEZ9zMlRe7lZ0c3COg K0Veg== X-Received: by 2002:a05:6512:8059:b0:5ae:a89c:3cd8 with SMTP id 2adb3069b0e04-5aed50b4a23mr30279e87.46.1783106111832; Fri, 03 Jul 2026 12:15:11 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:4320:f42:12a1:e009:28f8:7d6b? ([2a00:1fa0:4320:f42:12a1:e009:28f8:7d6b]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b4adf590asm4217581fa.25.2026.07.03.12.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 12:15:11 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 22:15:09 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] usb: dwc3: fix dwc3_readl() and dwc3_writel() calls in dwc3_ulpi_setup() To: Ben Dooks , Thinh Nguyen , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@kernel.org References: <20260703162033.2847599-1-ben.dooks@codethink.co.uk> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20260703162033.2847599-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/3/26 7:20 PM, Ben Dooks wrote: > The dwc3_ulpi_setup() calls the register read and write calls with Hmm... maybe "does the register read/write calls"? > dwc3->regs when both these calls take the dwc3 structure directly. > > Chnage these two calls to fix the following sparse warning, and Change. > possibly a nasty bug in the dwc3_ulpi_setup() code: > > drivers/usb/dwc3/core.c:796:45: warning: incorrect type in argument 1 (different address spaces) > drivers/usb/dwc3/core.c:796:45: expected struct dwc3 *dwc > drivers/usb/dwc3/core.c:796:45: got void [noderef] __iomem *regs > drivers/usb/dwc3/core.c:798:40: warning: incorrect type in argument 1 (different address spaces) > drivers/usb/dwc3/core.c:798:40: expected struct dwc3 *dwc > drivers/usb/dwc3/core.c:798:40: got void [noderef] __iomem *regs > > Cc: stable@kernel.org > Fixes: 9accc68b1cf0 ("usb: dwc3: Add dwc pointer to dwc3_readl/writel") > Acked-by: Thinh Nguyen > Signed-off-by: Ben Dooks > --- > v2: > add fixes and cc to stable > v3: > fixed the fixes: tag to point to correct commit [...] MBR, Sergey