From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbdEBRrI (ORCPT ); Tue, 2 May 2017 13:47:08 -0400 Received: from mout.web.de ([217.72.192.78]:52971 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbdEBRrC (ORCPT ); Tue, 2 May 2017 13:47:02 -0400 Subject: [PATCH 1/3] net/atm: Combine four seq_printf() calls in mpc_show() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Tue, 2 May 2017 19:46:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jjUdU8NdhOX156W8fzTBfHDNm8u7FbTnv7kWgnZKsaAg1KBztvl mKVYm9oalLX9h931r3tZrcLG2ResGTOc3wj8ARYcz+USoTsqCHkrde++H+telkhNwwx+yQx oVuGXNo0y9ixcvlJ2mmt3vR6U9ujdPivdWFxJAitXHwwnsSP4dzsHIIJx4H87r+fi11T9Jl OAsZnkTT4wSAWXRgA52Zg== X-UI-Out-Filterresults: notjunk:1;V01:K0:XI7mGAC1gAc=:XE0BQhklzkcbLUW6oUgrOC YYgUOKASLdzoctNlyiOU2p0J/SiUnGCob0nGqu5P6wI7KNeQg1qM8JbWSDPbCmtwktscLsFbr E6gqiOv27tdNC9kDupLf0WfyQG2M4IcWs0o0jVN7Gv55aMNt+lNCuqdeIjLPru9/CemxBupuC MqCoLAo4Q7L+3XSeJQYPQ7xUO45Y2NJRxW4glwO86lZpktg9VVGfSC00HxvqeXE967Hp8LfHK vCZDiTHbztTBlCCPdiy0+IK+g63KyVKVidceuIPnlVgsYv2kT+vRcs4aRlXTQ59xu2vQKG670 91rT78OIBkE5n6XeMfZorg4by7cbBz3Fowkg2lvgJTBeZ83UmxbubHaEsf9ashqgMsJmsUP03 +3REG7Nbx2XypT4nvbv4lRbTOz0S3TeV6y+6TBXZfQCABNv49ZSPA/PbPqxAQBAub1kq3/CVl 3pI+JUw56p3EyeLBBmab0s63Ye09Cjm/HTte/qp5b09KTj9il4x4snowMgFq1yUuWYvayE0Im XObmMfYLeNENQaHh60SYvTpHE1viUFQuDNJ/8Jw3vYDDVxolDbtyW2vw/axFmLOtDDmGX/8Va kDB1cgL1rtyIT4cPqhKBIlTn0PsIXFu0CYdbJUaNbYQGoGExgA3/zqFHBznmDKt/9HVpmtJxo 96zDmD++EaWfuutIU/Hd/t/ieQ/Ri6xEd+dLGfTBwSsW+8Yvm+axLavg0gwWhi69E8lO00Y8p EKdWoAb5L+JekkdiehXXg7Zxbe6kzySiUCt8fcKzIBfJfuR6/K056wJyIvKTWnhqMBJSbpEJf YemZ7W2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 18:52:58 +0200 Some data were put into a sequence by four separate function calls. Print the same data by two function calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/atm/mpoa_proc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/atm/mpoa_proc.c b/net/atm/mpoa_proc.c index 2df34eb5d65f..6ea6028fd865 100644 --- a/net/atm/mpoa_proc.c +++ b/net/atm/mpoa_proc.c @@ -145,8 +145,8 @@ static int mpc_show(struct seq_file *m, void *v) return 0; } - seq_printf(m, "\nInterface %d:\n\n", mpc->dev_num); - seq_printf(m, "Ingress Entries:\nIP address State Holding time Packets fwded VPI VCI\n"); + seq_printf(m, "\nInterface %d:\n\nIngress Entries:\nIP address State Holding time Packets fwded VPI VCI\n", + mpc->dev_num); do_gettimeofday(&now); for (in_entry = mpc->in_cache; in_entry; in_entry = in_entry->next) { @@ -165,7 +165,7 @@ static int mpc_show(struct seq_file *m, void *v) } - seq_printf(m, "\n"); - seq_printf(m, "Egress Entries:\nIngress MPC ATM addr\nCache-id State Holding time Packets recvd Latest IP addr VPI VCI\n"); + seq_printf(m, + "\nEgress Entries:\nIngress MPC ATM addr\nCache-id State Holding time Packets recvd Latest IP addr VPI VCI\n"); for (eg_entry = mpc->eg_cache; eg_entry; eg_entry = eg_entry->next) { unsigned char *p = eg_entry->ctrl_info.in_MPC_data_ATM_addr; for (i = 0; i < ATM_ESA_LEN; i++) -- 2.12.2