From: "Kumar, Udit" <u-kumar1@ti.com>
To: Beleswar Padhi <b-padhi@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
<kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>
Cc: <afd@ti.com>, <hnagalla@ti.com>, <jm@ti.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j742s2-mcu-wakeup: Override firmware-name for MCU R5F cores
Date: Fri, 29 Aug 2025 11:48:47 +0530 [thread overview]
Message-ID: <c542ad3f-8e6d-405a-92d3-4e45cbcfc2a3@ti.com> (raw)
In-Reply-To: <20250823163111.2237199-1-b-padhi@ti.com>
On 8/23/2025 10:01 PM, Beleswar Padhi wrote:
> The J742S2 SoC reuses the common k3-j784s4-j742s2-mcu-wakeup-common.dtsi
> for its MCU domain, but it does not override the firmware-name property
> for its R5F cores. This causes the wrong firmware binaries to be
> referenced.
>
> Introduce a new k3-j742s2-mcu-wakeup.dtsi file to override the
> firmware-name property with correct names for J742s2.
>
> Fixes: 38fd90a3e1ac ("arm64: dts: ti: Introduce J742S2 SoC family")
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
> v2: Changelog:
> 1. Posted this patch as a fix as decided in v1, so added Fixes tag.
>
> Link to v1:
> https://lore.kernel.org/all/20250522073426.329344-2-b-padhi@ti.com/
>
> .../arm64/boot/dts/ti/k3-j742s2-mcu-wakeup.dtsi | 17 +++++++++++++++++
> arch/arm64/boot/dts/ti/k3-j742s2.dtsi | 1 +
> 2 files changed, 18 insertions(+)
> create mode 100644 arch/arm64/boot/dts/ti/k3-j742s2-mcu-wakeup.dtsi
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j742s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j742s2-mcu-wakeup.dtsi
> new file mode 100644
> index 000000000000..61db2348d6a4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j742s2-mcu-wakeup.dtsi
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/*
> + * Device Tree Source for J742S2 SoC Family
> + *
> + * TRM: https://www.ti.com/lit/pdf/spruje3
> + *
> + * Copyright (C) 2025 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + */
> +
> +&mcu_r5fss0_core0 {
> + firmware-name = "j742s2-mcu-r5f0_0-fw";
> +};
> +
> +&mcu_r5fss0_core1 {
> + firmware-name = "j742s2-mcu-r5f0_1-fw";
> +};
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
> diff --git a/arch/arm64/boot/dts/ti/k3-j742s2.dtsi b/arch/arm64/boot/dts/ti/k3-j742s2.dtsi
> index 7a72f82f56d6..d265df1abade 100644
> --- a/arch/arm64/boot/dts/ti/k3-j742s2.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j742s2.dtsi
> @@ -96,3 +96,4 @@ cpu3: cpu@3 {
> };
>
> #include "k3-j742s2-main.dtsi"
> +#include "k3-j742s2-mcu-wakeup.dtsi"
next prev parent reply other threads:[~2025-08-29 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 16:31 Beleswar Padhi
2025-08-29 6:18 ` Kumar, Udit [this message]
2025-09-12 9:48 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c542ad3f-8e6d-405a-92d3-4e45cbcfc2a3@ti.com \
--to=u-kumar1@ti.com \
--cc=afd@ti.com \
--cc=b-padhi@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=jm@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®