From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5786AC4332F for ; Wed, 6 Apr 2022 00:17:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1583146AbiDEXvX (ORCPT ); Tue, 5 Apr 2022 19:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1450214AbiDEPvX (ORCPT ); Tue, 5 Apr 2022 11:51:23 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4412D12865B for ; Tue, 5 Apr 2022 07:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=yDe80dB3PcLLjC73bVCnCnNNULyXZtKg1Crra+A5bJo=; b=MKQPYpOohaUf88JeLFDJOO+/sW rPWNUODd1G7R/GWtLPxD35hsZzHm7lfA2fgTRY1mJ918gJo/J7wkGFjIa2wz2qoQlxOzYC53p7OAx WOKm2lEmAhkUtYkXsmFahxYNzl5WHpw1jT+/VU93Lv75N69qopw81Gf7e8O88HavJETlyLn63CNB4 /+5jUfCBH6tprXYmnn6c3KdrvsUFUZmz35pEvSfhaTOeJcTkt/A47k0zJlwqfo9QL0tricRrzIcPf vw7gSENAliOUQALLMW/5mSYZ3lDnzVPkcW9wT71UGl1HMUaCyqGMXK8ACLdR0z6ACotd8vpEsgXJ8 TQhbEaHQ==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbkLJ-001sTR-9Z; Tue, 05 Apr 2022 14:39:38 +0000 Message-ID: Date: Tue, 5 Apr 2022 07:39:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/format_helper: fix a kernel-doc typo Content-Language: en-US To: Javier Martinez Canillas , Simon Ser Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org References: <20220403232902.1753-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/22 23:26, Javier Martinez Canillas wrote: > On 4/5/22 08:12, Simon Ser wrote: >> On Monday, April 4th, 2022 at 23:35, Randy Dunlap wrote: >> >>> On 4/4/22 09:04, Simon Ser wrote: >>> >>>> Both doc patches pushed, thanks. I had to manually edit them because they >>>> wouldn't apply cleanly. Next time, please use git-send-email (see >>>> https://git-send-email.io/ for setup instructions). >>> >>> That's odd. I did use 'git send-email' and I don't usually have any >>> problems (AFAIK). I'll check those setup instructions. >> >> Hm, maybe the issue isn't git-send-email, but the way the patch was >> generated? I had to manually edit these lines for the first patch to work: >> >> --- linux-next-20211217.orig/include/drm/drm_file.h >> +++ linux-next-20211217/include/drm/drm_file.h >> >> I changed these to: >> >> --- a/include/drm/drm_file.h >> +++ b/include/drm/drm_file.h >> >> This wasn't enough for the second patch, I had to re-do the changes by hand >> from scratch. >> > > Yes, I believe the suggestion should be to use git-format-patch instead. > > To make sure that was is posted can be consumed by the git-am command. Considering that I am not using git, I think it will be difficult to use git-format-patch. (git-send-email is independent of git.) Still, this is the first time in many years that I have heard of this problem. Thanks for the info and insights. -- ~Randy