From: bot+bpf-ci@kernel.org
To: maze@google.com,zenczykowski@gmail.com,ast@kernel.org,daniel@iogearbox.net
Cc: netdev@vger.kernel.org,linux-kernel@vger.kernel.org,bpf@vger.kernel.org,maze@google.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Add tests for bpf_sockopt is_compat field
Date: Thu, 13 Aug 2026 12:14:12 +0000 (UTC) [thread overview]
Message-ID: <c5481925e539bd3a00343eb765e1f50ea99d0878c7ca3858d68d460b7076c95f@mail.kernel.org> (raw)
In-Reply-To: <20260813112039.247862-2-maze@google.com>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
> selftests/bpf: Add tests for bpf_sockopt is_compat field
>
> Sync tools/include/uapi/linux/bpf.h with the addition of the 'is_compat'
> field in 'struct bpf_sockopt' and add test cases to 'prog_tests/sockopt.c'
> to verify context access permissions:
>
> - Test reading 'ctx->is_compat' in 'cgroup/{g,s}etsockopt'
> (expecting 0 in native execution).
> - Check verifier rejects writes to 'ctx->is_compat'
> in 'cgroup/{g,s}etsockopt'.
>
> Tested via:
> tools/testing/selftests/bpf/vmtest.sh -- ./test_progs -t sockopt
This isn't a bug, but would it be worth separating the 'Tested via:'
line with a blank line and saying explicitly that the compat==1 path is
not reachable from a native test_progs build, so readers know what the
new cases do and do not cover?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31696027015
next prev parent reply other threads:[~2026-08-13 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 11:20 [PATCH bpf-next 1/2] bpf: Support cgroup {get,set}sockopt hooks for compat syscalls Maciej Żenczykowski
2026-08-13 11:20 ` [PATCH bpf-next 2/2] selftests/bpf: Add tests for bpf_sockopt is_compat field Maciej Żenczykowski
2026-08-13 12:14 ` bot+bpf-ci [this message]
2026-08-13 12:59 ` [PATCH bpf-next 1/2] bpf: Support cgroup {get,set}sockopt hooks for compat syscalls bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5481925e539bd3a00343eb765e1f50ea99d0878c7ca3858d68d460b7076c95f@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=yonghong.song@linux.dev \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®