From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E693F4DCE for ; Thu, 28 May 2026 13:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779974809; cv=none; b=kHUfmlrrZWS697UtCVA7eAZrWGGgI71d/jfWC5llwHMdQALZgzdZtJnyPc5pLcV0zTx2zXfFI0/wBZlabLyEewz0tHawRGf7TmHe6eggIQUNS/5KvyWRHsEq4STi3tF4PLiBzZBF9cJflhhSVNIzXZ0f9RsFRx4PVJf3ChFTI4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779974809; c=relaxed/simple; bh=ZECEnHVkpwBXXqBG5VF9HeKNplqjJbGvJUGwL/valHc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=buLVTtXKRRHl3CIwl5ZheIHW+sjqxmGhJ3V3iK2KGJ6CYrN4iz+etgq6PVAmaVchi709g7SusuTl3Xc8GIKLqIyR0xitx+z21rHZd1rqUz9vd/f3ArByTYX7sszBuMV+SzZANGcoJuUCwiZAtohBZxoR3DDP0GWZqq8x4OBG3BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eNAoGpRc; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eNAoGpRc" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43eb05b1875so6757446f8f.3 for ; Thu, 28 May 2026 06:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779974805; x=1780579605; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=07cGekjSMMRgi+j+3CPWjLKKZCOIFFGPCDT3OAaoCe0=; b=eNAoGpRcCmoC5hLS5LDWADSUgsRBUGuRmG+ha3pwKqHrd5cGyQQPYMRXstZ6Pvhs5R fVP/Iwy3McMiPle5ly7K1b+u3+yK2bi/E/eIFFXY26xnqPBoN0JIQt/92dPvSr/u88jY Hikv9ZnAcyQqg+0fS5JJVXrCtZ5VD+KXnwNuUdpd1125weeH2vnaNq0Lvd2Ue95Fk2Fg AXf6abxbkpB3No588FmmwQzyjRNqwVu2Qf0SEO1rpg0nvHXgCXqSy0AWnvtUR5+Lr0lJ C7gVvlaoK7/wW1vRH5LlLv0n0MZbNrAnWqcJhu15kiMtMgOpDCEhZ6ew0gzIaiih7W1R CCKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779974805; x=1780579605; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=07cGekjSMMRgi+j+3CPWjLKKZCOIFFGPCDT3OAaoCe0=; b=EzHD2BB7uBr9BOFgo1MzFmsiIv3LbeuhPj67h2uwyzEgemLmKy8r6wBAfNmJGrCS7Z 5DS+S5RL+XRjUgDY9YpfFpzMhRAJGHJvWJqg8Ele9tbds1W118vOgnExB2qODNOLnUPn 1JBZZeFlUeSK/vsyQDWwyQ0G/eq0ODmY9PjqS44Li9DfG3rWQY9NcxkJhs763dwC9RW7 7NgvZMG9YgigliO1BNVhQvJWpMXpE0lp5tRe8EMr8MQtjV82+NRuu+rlElQ8AA8nQGpJ 47sCPppMiCiHOe0pzCJBFGjaqUViGJ6raPNShXjQCjYNX84X8BzMSWh4OGkP3l47mi4a aYLw== X-Forwarded-Encrypted: i=1; AFNElJ+RAd4WG7lVn3rucoT77p9EQSyUXaK6sOJysjyPrKzn5hphphJKTx0UQTNU12A6WlOooRgEqv9oRvB6DsI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Z9A5MCAVi0aC2cCtotlyeydhBtcrml8nk2x4OUp0s+elOtWi 3wudNoQQ1ZJ9VjJ+a2ht2ouA3wYUpzHMjUUXoxWGgjNXx259XH1SEp2mYOtZYdZHPOQ= X-Gm-Gg: Acq92OEjEBUTZnwEO//vFQmVyOWm5UrIor1gOWWyBIGmiEFcPOtYBg6TiOmhDZKhlMa LvsBxMKRt7C+lbrCMA/UUgYEWk2wwXWcwIGuzDABzdwLFy/XofzG8nLt5wGcM7Xt2QQKtXU5CTf 2gJbtL6j8kpp8ceDRJf+6zDC26jvsXXMoBKJpTAe2P96PeDFGVKYwgY4PJu/PLWdnwmnyfTpMiM xyaUaEPP8UtfHqwD6tOkLI3ckbqQHqxhx28rP0ps6bc7AphfCN4AEkkYvA3OFgLSpBa2nmVDyMG G9bBrxPmQLLW7ouvjP9meRHDxPnrvsA5EZEn9iR+fhJv3lDC8y1MOIKioJTbD1Kh4sppYtS0hvs 0lZ0n0ktgDleI5nrc2w4I6kKl13hPYE1FDRWf+vQO3sMgqaiAMzsIjSDjkLDU1MDDqlzH8tHGRd px+E3wtQ1lB+coLkTh+9PcoqBbyrlC+BYxdYOB6VKsoP8= X-Received: by 2002:a05:6000:4029:b0:45e:e9ac:42e8 with SMTP id ffacd0b85a97d-45ee9ac443bmr4094099f8f.18.1779974804420; Thu, 28 May 2026 06:26:44 -0700 (PDT) Received: from [172.20.10.2] ([37.167.60.147]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45edb54a3c3sm14114139f8f.8.2026.05.28.06.26.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2026 06:26:43 -0700 (PDT) Message-ID: Date: Thu, 28 May 2026 15:26:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v4 0/6] media: qcom: iris: add support for decoding 10bit formats To: Wangao Wang , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Bryan O'Donoghue References: <20260521-topic-sm8x50-iris-10bit-decoding-v4-0-8ff8fce3f904@linaro.org> <12102d68-da35-47ea-a972-28cb6d54ce1c@linaro.org> <12da2953-fe51-4999-9656-2b42a7897f91@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <12da2953-fe51-4999-9656-2b42a7897f91@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Wangao, On 5/27/26 06:15, Wangao Wang wrote: > I tested the v4 patch using the gst command you provided earlier. The decoded output still has the previous plane misalignment issue, but all frames are decoded successfully. When viewing the raw data with an image player at 1920x1080 resolution, the first frame looks correct but subsequent frames appear shifted. If viewed at 1920x1088 resolution, there are artifacts at the bottom of each frame. I've attached the images. > > Also, have you tested the 720p case? I can't get it to run on my end. Thanks for the report but I don't have access to the Purwa platform you use, I've run test with multiple resolutions with display using P010 and QC10, and ran fluster aswell and all passed on SM8550 and SM8650. I'll test it on the Hamoa T14S I have which should be the closest to purwa, but it uses the same driver setup as SM8550 so I expected it to work the same. Could you indicate which iris firmware you're using ? Could you try passing the fluster h265 main10 test suite with gstreamer ? fluster download -c h.265 fluster run -d GStreamer-H.265-V4L2 -ts JCT-VC-HEVC_V1 -q -s -j1 The picture you send looks like there's a mismatch with the kernel and firmware setup of planes offsets. Could you check if there's a Purwa specific firmware property to set for 10bit decoding ? Neil > > On 2026/5/26 20:45, Vikash Garodia wrote: >> >> On 5/26/2026 6:09 PM, Neil Armstrong wrote: >>> On 5/26/26 09:53, Vikash Garodia wrote: >>>> >>>> On 5/21/2026 2:54 PM, Neil Armstrong wrote: >>>>> This adds the plumbing to support decoding HEVC, VP9 and AV1 >>>>> streams into 10bit pixel formats, linear and compressed. >>>>> >>>>> This has only been tested on SM8550 & SM8650 with HEVC, and was >>>>> inspired by Venus, DRM MSM and the downstream vidc driver for the >>>>> buffer calculations and HFI messages. >>>>> >>>>> Gstreamer support for QC08 and QC10 need the MR at [1] to be applied, >>>>> but NV12 and P010 works out of the box with mainline Gstreamer. >>>>> >>>>> Fluster HEVC results on SM8650 using Gstreamer: >>>>> >>>>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 141/147 >>>>> The failing test case: >>>>> - Pixel Format mismatch >>>>>   - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010 >>>>> - Unsupported resolution >>>>>   - PICSIZE_A_Bossen_1 - resolution is higher than max supported >>>>>   - PICSIZE_B_Bossen_1 - resolution is higher than max supported >>>>>   - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported >>>>>   - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported >>>>> - CRC mismatch >>>>>   - RAP_A_docomo_6 >>>>> >>>> >>>> >>>> >>>> >>>>> >>>>> Total for iris_driver device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0 >>>>> >>>>> [1] https://gitlab.freedesktop.org/gstreamer/gstreamer/-/ merge_requests/8195 >>>>> >>>>> Signed-off-by: Neil Armstrong >>>>> --- >>>>> Changes in v4: >>>>> - Picked review tags >>>>> - Use u32 instead of __u32 >>>>> - Explicit DPB >>>>> - Drop NULL and use >>1 in q10c buffer calc >>>>> - Drop selicolon after switch statementr >>>>> - Correctly align HFI_PROP_UBWC_STRIDE_SCANLINE entry >>>> >>>> Its not very clear. Does this fix the issue reported here [1] ? >>>> >>>> https://lore.kernel.org/linux-media/fb377b11-c54c-4bd9-bf12- cf19d6484c66@oss.qualcomm.com/ >>> >>> I wasn't able to reproduce the issue, and the reporter never answered my questions so far. >>> >>> Neil >> >> It would be nice to add the reviewers directly as well. >> >> adding Wangao now. >> >>> >>>> >>>>> - Rebase on media next tree after the file split >>>>> - Link to v3: https://patch.msgid.link/20260511-topic-sm8x50- iris-10bit-decoding-v3-0-7fc049b93042@linaro.org >>>>> >>>>> Changes in v3: >>>>> - Added review tag on patch 1 >>>>> - Limited stride command to AV1 decoding only >>>>> - Link to v2: https://patch.msgid.link/20260417-topic-sm8x50- iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org >>>>> >>>>> Changes in v2: >>>>> - Fixed bug breaking 8bit decoding >>>>> - Dropped filtering on G_FMT while waiting for soure change >>>>> - Dropped format filtering on ENUMFMT >>>>> - Switched ALIGN(x, 192) to roundup(x, 192) because ALIGN works only with Power Of Two numbers >>>>> - Cleaned and refactors the width/height/stride calculations >>>>> - Cleaned and redesigned the buffer calculations functions with proper comments and var names >>>>> - Passed fluster and v4l2-compliance to check for non regression >>>>> - Tested on SM8550 >>>>> - Added missing V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 with made gstreamer fail decoding >>>>> - Link to v1: https://patch.msgid.link/20260408-topic-sm8x50- iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org >>>>> >>>>> --- >>>>> Neil Armstrong (6): >>>>>        media: qcom: iris: add helpers for 8bit and 10bit formats >>>>>        media: qcom: iris: add QC10C & P010 buffer size calculations >>>>>        media: qcom: iris: gen2: add support for 10bit decoding >>>>>        media: qcom: iris: vdec: update size and stride calculations for 10bit formats >>>>>        media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats >>>>>        media: qcom: iris: vdec: allow GEN2 decoding into 10bit format >>>>> >>>>>   drivers/media/platform/qcom/iris/iris_buffer.c     | 195 +++++++++ + ++++++++++- >>>>>   drivers/media/platform/qcom/iris/iris_hfi_gen2.c   |   8 +- >>>>>   .../platform/qcom/iris/iris_hfi_gen2_command.c     |  75 +++++++- >>>>>   .../platform/qcom/iris/iris_hfi_gen2_defines.h     |   1 + >>>>>   .../platform/qcom/iris/iris_hfi_gen2_response.c    |  37 +++- >>>>>   drivers/media/platform/qcom/iris/iris_instance.h   |   2 + >>>>>   .../platform/qcom/iris/iris_platform_common.h      |   1 + >>>>>   drivers/media/platform/qcom/iris/iris_utils.c      |  16 +- >>>>>   drivers/media/platform/qcom/iris/iris_utils.h      |   2 + >>>>>   drivers/media/platform/qcom/iris/iris_vdec.c       |  42 ++++- >>>>>   10 files changed, 364 insertions(+), 15 deletions(-) >>>>> --- >>>>> base-commit: 86693e86019a7466be961fd4f45d407cc0b0ba0a >>>>> change-id: 20260408-topic-sm8x50-iris-10bit-decoding-074c3ac7975c >>>>> >>>>> Best regards, >>>>> -- >>>>> Neil Armstrong >>>>> >>>> >>>> Regards, >>>> Vikash >>> >> >