From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38110C432BE for ; Thu, 2 Sep 2021 08:12:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 127A761074 for ; Thu, 2 Sep 2021 08:12:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244260AbhIBINT (ORCPT ); Thu, 2 Sep 2021 04:13:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243655AbhIBINS (ORCPT ); Thu, 2 Sep 2021 04:13:18 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1C70C061575 for ; Thu, 2 Sep 2021 01:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=T8iMcVMtgnL9iuUQ7xEHqtPN2nGklJHWa5SfBMcFyr0=; t=1630570340; x=1631779940; b=CW13c4Hip6eJx9WndG4zJdN3BVXo3AbXyV5lJBubgD5cdXV 9ZpUxmM5ck7vweR1OTmLoO12xQz3OIissWmFsY5gc44TFqdn9SQl55rxWnL20Ri3O93r7OscLo1Us I5Q+yuC64WZ+gW14+i/6rG9uB72hyuxb/9KKVzi8GOHHPHijurb7uTlgWdeTHGP8Vw2DAZXHk4BYn SDu2pcIp1BaKkwlJc7bh+d7p0AUUr8tHmyznS3n+hntnE9SBdrfqywdO35wTbfVssWoYHlRkcUNOD Mn9XMTlRwEtnUObNqlCoM3tmdAiTPVMjCc+qqfiAzYDvCorSgTXbd5/Q4KrXy5Xw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1mLhpI-001WhA-0D; Thu, 02 Sep 2021 10:12:00 +0200 Message-ID: Subject: Re: [PATCH] drm/ttm: provide default page protection for UML From: Johannes Berg To: Anton Ivanov , Randy Dunlap , linux-kernel@vger.kernel.org Cc: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= , Christian =?ISO-8859-1?Q?K=F6nig?= , Huang Rui , dri-devel@lists.freedesktop.org, Jeff Dike , Richard Weinberger , linux-um@lists.infradead.org, David Airlie , Daniel Vetter Date: Thu, 02 Sep 2021 10:11:59 +0200 In-Reply-To: <347e4cb8-a7c5-9e1b-16bc-96805442d35b@cambridgegreys.com> References: <20210902020129.25952-1-rdunlap@infradead.org> <9faacbc8-3346-8033-5b4d-60543eae959e@cambridgegreys.com> <0887903c-483d-49c7-0d35-f59be2f85bac@cambridgegreys.com> <288a2d4dbcb1e6b0fbeff6da86569aa92df09202.camel@sipsolutions.net> <347e4cb8-a7c5-9e1b-16bc-96805442d35b@cambridgegreys.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-09-02 at 09:10 +0100, Anton Ivanov wrote: > On 02/09/2021 08:43, Johannes Berg wrote: > > On Thu, 2021-09-02 at 07:19 +0100, Anton Ivanov wrote: > > > > > > > > > > I have a question though - why all of DRM is not !UML in config. Not > > > > > like we can use them. > > > > > > > > I have no idea about that. > > > > Hopefully one of the (other) UML maintainers can answer you. > > > > > > Touche. > > > > > > We will discuss that and possibly push a patch to !UML that part of the > > > tree. IMHO it is not applicable. > > > > As I just said on the other patch, all of this is fallout from my commit > > 68f5d3f3b654 ("um: add PCI over virtio emulation driver") which is the > > first time that you could have PCI on UML. > > > > Without having checked, in this particular case it's probably something > > like > > > > depends on PCI && X86_64 > > > > as we've seen in other drivers (idxd, ioat). > > > > The biggest problem is probably that UML internally uses X86_64 > > (arch/x86/um/Kconfig), which is ... unexpected ... since CONFIG_X86_64 > > is typically considered the ARCH, and now the ARCH is actually um. > > > > I think we can just fix that and get rid of this entire class of > > problems? Something like > > > > https://p.sipsolutions.net/fbac19d86637e286.txt > > Good idea. I suspect that DRM will not be the only thing to pop up out > of this so we might as well fix it "at the top". Yeah I sent like a handful of similar patches ... I'll send that patch out in a minute, just writing a reasonable commit log. Seems to build & work fine for me. johannes