From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333943D647F for ; Fri, 3 Jul 2026 13:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783085493; cv=none; b=c+IqFG/OjkurudoEG0+gK0XHh8ydhwaf2Gy2dFyD5QOEUvJUPw1OR3w3Zsej964leiIPv8Wu34A+OqbVobsx5ak7V8DzZjdtqTWq5Zd4yV7v3NDEA6dcFxsWx7TSaxr3cf004WgqEItIf5yuUPbJDhyVbkfsZhcKiu1N9chSkbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783085493; c=relaxed/simple; bh=vAT1lNSIa/PrMnhwIJYzBDd3jyA6FVn2AwWFXgDKoMs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DFPO9k/vL94ntBUlSYescLqAiTi+jlx4NWlINmZRaYY5CtgdDs6MC6oAIsut84s+XY0PUDAwCuvw8q3ChB4r622bxvdXZGWd5wijRCLqXgPjSg83rUvGWek6EzirSaq7pqcndJBLpf3B+PpfUjspQ1MfHG24Atw0sQvtzgrkFU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AN60XDbp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TaAOy+3T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AN60XDbp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TaAOy+3T" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6637Zmt33410166 for ; Fri, 3 Jul 2026 13:31:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ffuv1ybSu7eD+tb1QtC3S+4KTVX6BTRlHx0MrDnNEcs=; b=AN60XDbpjhkXSQzi ujOiH8Ua/axnEYIpjmylkBhFMJs10MVOJgfpAsvW26HxIm0q6exCqcCbeTQfJjuJ KCY5q/6Ws7IUFevmP6oM9a/1widCprfM16S1Dqk0Y2H+ffhz9EcbbsUG49oXVjTI LuqxFol3o5PHGoCIT/IhLFXwMr96Xyv/8s/DKfC6iWurEMri9dbmUMKLGNMU5krp y2HHYTJqAlKK+E4CT/Xs+ULZIsJTevsDFGo7EFrzeh5X3/wzOleysBgUSej0AJuN sMbXT0rckSFjD2u9h8UFrrokXch72TLy24//2PlAPWwgFhtPrdpAP+dyiOeuJvte fzDvyg== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f68u31aqu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 13:31:31 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7e9facfe85cso37904a34.1 for ; Fri, 03 Jul 2026 06:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783085491; x=1783690291; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ffuv1ybSu7eD+tb1QtC3S+4KTVX6BTRlHx0MrDnNEcs=; b=TaAOy+3Tjj9z4J+VfKJrCHqNoy3uBf3BNV3S0ITUKux4vILg2uMXO5FPdkdrQK6+Q2 PRp3p3cbTmx7YTS6bdJfwYC1Z5z9kou6UuNiOSIh4+XAZPrjcrgiKZhFV/IHGVyqqVJD aCX4GpH3gy3aEHH7mxyMELFrRbmrL7IN+lCpcwNth7iuh2mCNoPvjO113cHdiWY2f6u6 FVV9mabGRvxNgQYUkty56pcvFtFUZOvKMqy44Htsfzw9MvGIYNCOXdiIpNGU74v+Wjpm yYnwwuPm35/5mANdd+fb27F+lUmafT+oIAH87V6gIQwURDYxeDRc3XVDcro9KjNB76V2 3W3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783085491; x=1783690291; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ffuv1ybSu7eD+tb1QtC3S+4KTVX6BTRlHx0MrDnNEcs=; b=OGH3BaJXPLECy9lQxE1dmfRrX2nag44BPh/WQvGV1wz560jvRQTYVHz4kyqaECFVp5 sd2KeVyG9vrBdwFL++cH264sfowK4KMXfhkQFO0J81pBkqOVesFQpvvIU/tFGNg1MlQQ hhpwwEhHM1CLrd9+ggNAAwMECofiXiOqei8NwsvIh0LecKoRuHKY+0d75RTZk7QXSsOy BUOOyd0hrKwIryODXKutJ2blIiiscjvw10ZNhO4uVE3IreNxIQ8ooD3+H2jnvFiTUx61 5Kh0pWIlbO4OLd3fvyk+PpKmE3RzRArlt2yNdE2EaB7m0zZOvm12i9kHUZyasiuIgVs8 3RUA== X-Forwarded-Encrypted: i=1; AFNElJ9xnzPjn9VvEeA36rllN3usoaSxCdJWnZfbaLy2mgvVk2KyYKqmeLdtF0DoTOE25eM4oZBROOkrqp9mlUg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo7cao9e4235oca8Vi6G3H+7cQgbFiCT1ekXwOlqJieDW6mTg9 MFyRDw0tyeOwHzmyKyy6Y7hybPBeJOYVyzO1IVoMDlfMLKpFDVlJcj7TcU0G++jYxHPnlOEBYts uuYYgQxUNPgS50Z4SoUYDA31L8ljfhCatBaxI4yvwanxxCV11mBwJyJ835eS/XfcE/4w= X-Gm-Gg: AfdE7cl59fRHXGQQiOS9QbcBfDWfjMut+kICE4E8L8mqSQo2Od6puUUihv8AOOXM79y 6VKOI0xE1zJqiZdBZrSuMmDUGkhltJpKS1nVh/ii/JnBMXxJ7wngx6WqXFaWLiiMRo76A2FTqsH 2aRBK+CFz4zTUeclZDYRCf7A/uDLXFHpDWmkksWHE2WW0p/9uhNyimvNLmjiAvrUyWf8CwOtRHY buIxrxS1bsZwGzejrK466nBHsFtnNX88hVc3bUm1o1agvdEM4QLXsWWIXYiMvueTt7EdxKusExQ nP7tBLBV8jz60AIxfjKHXf5NwqjAcV/YsI31TD+wA2GPZJYBffbalvhsYxYOn618ixLTJrTvBf6 iTCewgoYvneItdshJzMEfo2SdMmcyiOzFcHw= X-Received: by 2002:a05:6830:2696:b0:7e9:d089:d7bf with SMTP id 46e09a7af769-7eb4cc1678dmr4643676a34.4.1783085490472; Fri, 03 Jul 2026 06:31:30 -0700 (PDT) X-Received: by 2002:a05:6830:2696:b0:7e9:d089:d7bf with SMTP id 46e09a7af769-7eb4cc1678dmr4643659a34.4.1783085490043; Fri, 03 Jul 2026 06:31:30 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b628c134sm277001666b.36.2026.07.03.06.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 06:31:29 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 15:31:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm7125-samsung: add initial device tree To: Erikas Bitovtas , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hansson , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260703-sm7125-samsung-v1-0-3e5f752048c1@gmail.com> <20260703-sm7125-samsung-v1-3-3e5f752048c1@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260703-sm7125-samsung-v1-3-3e5f752048c1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: cq2bAhuIvNfA1V9H4EENF6XB-7XbalA3 X-Proofpoint-ORIG-GUID: cq2bAhuIvNfA1V9H4EENF6XB-7XbalA3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDEzMiBTYWx0ZWRfX5eAzXRiAcCF9 EDuoOZhR2p6q5V6juXxAP9qp/bm0P1VDiryKR7WK0hyUCMI6Sf1R9hSQH0q+vst0JLNk5CrUPOX 0vAG/M9JV27fbMcKfuObpXXI7ZT3jcg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDEzMiBTYWx0ZWRfX+AJRUiTcwf0J X/cyvKzKzbMeEIvrj8ZuG+06sX8cYJA2Ra6YyquDkcZKwzNG10X3EsbWkecAjGvkQvMvJdb2GIP 6en9ppvdOAFgnN7p7asC7tR9lDmHaiAt0H4SqZUHuaHG+7sV7MvH6Fg4y9RiIsiobqhk+aKdESJ mc6leesnZ31Pq5K8L9y9rk/p0DvsYRgOh1bmenDIshsoZvS3HzeAPV3qbJ7Q1DjQA2JOyyx8Rak T2ERidwyPN+0y+T86Z/koIugVvFzs9RluKeUi6ZtV/AyfOJzbzL+/g31wkiJHrP4gGLv1MZVsHD TExs19BHSNBPA08dWI2a+UgCDKC/mtZn3gAUCOa5A8X7+cVIS/6vDyq+LP3inFwJbCzFF/vBV33 9X8NohxVqy2M+PLRqxXo9omD0jHWVC61HJnOTwNmV9qxfbU2JbMEZ3GDLtqcEhAwtn4sRNEc4og mq3sMmYv2gJwf4YFrLA== X-Authority-Analysis: v=2.4 cv=OaKoyBTY c=1 sm=1 tr=0 ts=6a47b9b3 cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=h45PUBSeg-F0hSU9p9MA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030132 On 7/3/26 9:59 AM, Erikas Bitovtas wrote: > Samsung Galaxy A52/A72 are devices released on atoll (SM7125) platform > in 2021. Add initial device tree for SM7125 Samsung platform with > support for: [...] hello, mainly just style nits > + rmtfs_mem: memory@f4f01000 { > + compatible = "qcom,rmtfs-mem"; > + reg = <0 0xf4f01000 0 0x200000>; 0 -> 0x0 (also in all similar cases) [...] > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&key_vol_up_default>, <&hall_sensor_default>; property-n property-names [...] > +&apps_rsc { > + pm6150-rpmh-regulators { > + compatible = "qcom,pm6150-rpmh-regulators"; > + qcom,pmic-id = "a"; have vou verified your reg settings? incorrect ones may lead to hw damage [...] > +&pm6150_pon { > + /* LinuxLoader fastboot implementation has most of it's commands removed > + * by Samsung, making it useless. So reboot to Odin download mode instead. > + */ /* * foo */ > + mode-bootloader = <0x15>; > +}; > + > +&pm6150_resin { > + linux,code = ; > + status = "okay"; let's keep an \n before 'status' [...] > +&tlmm { > + gpio-reserved-ranges = <59 4>; Do we know what they're connected to? If so, please add a comment, like in glymur-crd.dtsi [...] > +&usb_1 { > + qcom,select-utmi-as-pipe-clk; > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + dr_mode = "peripheral"; > + maximum-speed = "high-speed"; Does super-speed not work (if you also remove the qcom,select... above)? Konrad