From: Xiu Jianfeng <xiujianfeng@huaweicloud.com>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] cgroup: Remove out-of-date comment in cgroup_migrate()
Date: Wed, 24 May 2023 14:57:05 +0800 [thread overview]
Message-ID: <c56473be-facb-e0ea-246c-bdd5bf74c7cd@huaweicloud.com> (raw)
In-Reply-To: <ZG0PYH7a9Mw50bEl@slm.duckdns.org>
On 2023/5/24 3:09, Tejun Heo wrote:
> On Tue, May 23, 2023 at 07:14:56PM +0800, Xiu Jianfeng wrote:
>> From: Xiu Jianfeng <xiujianfeng@huawei.com>
>>
>> Commit 674b745e22b3 ("cgroup: remove rcu_read_lock()/rcu_read_unlock()
>> in critical section of spin_lock_irq()") has removed the rcu_read_lock,
>> which makes the comment out-of-date, so remove it.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>
> So, that removed rcu_read_lock() because it's implied by the irq disable but
> the comment content is still useful in describing what's preventing
> use-after-free. Can you please update the comment accordingly instead?
sure, I would send a v2.
>
> Thanks.
>
prev parent reply other threads:[~2023-05-24 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 11:14 Xiu Jianfeng
2023-05-23 19:09 ` Tejun Heo
2023-05-24 6:57 ` Xiu Jianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c56473be-facb-e0ea-246c-bdd5bf74c7cd@huaweicloud.com \
--to=xiujianfeng@huaweicloud.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®