From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 17D06C5CFC1 for ; Fri, 15 Jun 2018 06:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C056720864 for ; Fri, 15 Jun 2018 06:52:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C056720864 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755653AbeFOGwM (ORCPT ); Fri, 15 Jun 2018 02:52:12 -0400 Received: from gate.crashing.org ([63.228.1.57]:44658 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755577AbeFOGwL (ORCPT ); Fri, 15 Jun 2018 02:52:11 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id w5F6q2ZK026325; Fri, 15 Jun 2018 01:52:03 -0500 Message-ID: Subject: Re: [PATCH] drivers/of: Add devm_of_iomap() From: Benjamin Herrenschmidt To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Date: Fri, 15 Jun 2018 16:52:02 +1000 In-Reply-To: References: <23be2945b593a36d8fa1970bb579389c0f892a3e.camel@kernel.crashing.org> <3312487e2b61b8c2f265d210d14bbed8681a9ecc.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1 (3.28.1-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-06-15 at 08:16 +0200, Geert Uytterhoeven wrote: > Hi Ben, > > On Fri, Jun 15, 2018 at 1:51 AM Benjamin Herrenschmidt > wrote: > > On Thu, 2018-06-14 at 10:27 +0200, Geert Uytterhoeven wrote: > > > > --- a/include/linux/of_address.h > > > > +++ b/include/linux/of_address.h > > > > @@ -40,6 +40,11 @@ extern void __iomem *of_iomap(struct device_node *device, int index); > > > > void __iomem *of_io_request_and_map(struct device_node *device, > > > > int index, const char *name); > > > > > > > > +/* Request and map, wrapper on devm_ioremap_resource */ > > > > +extern void __iomem *devm_of_iomap(struct device *dev, > > > > + struct device_node *node, int index, > > > > + resource_size_t *size); > > > > + > > > > /* Extract an address from a device, returns the region size and > > > > * the address space flags too. The PCI version uses a BAR number > > > > * instead of an absolute index > > > > > > Do you need a dummy for !CONFIG_OF_ADDRESS, to aid compile-testing? > > > > I didn't think so, as of_address_to_resource() already has a dummy, so > > it should build fine. > > That dummy doesn't matter, as drivers/of/address won't be built if > !CONFIG_OF_ADDRESS anyway. Right but: - I moved it to lib/devres.c in my respun patch (because otherwise sparc won't get it) - The dummy is in include/linux/of_address.h, so devm_of_ioremap will compile fine either way. > I mean for compile-testing users of devm_of_iomap(). > > And according to kbuild test robot : > > > > (.text+0x1882): undefined reference to `devm_ioremap_resource' > > devm_ioremap_resource() has no dummy for !HAS_IOMEM and > OF_ADDRESS depends on !SPARC && (HAS_IOMEM || UML), > bypassing the HAS_IOMEM check on UML. > > Gr{oetje,eeting}s, > > Geert >