mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Liao, Chang" <liaochang1@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: <mhiramat@kernel.org>, <mark.rutland@arm.com>,
	<mathieu.desnoyers@efficios.com>, <linux-kernel@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH] function_graph: Simplify the initialization of fgraph LRU data
Date: Mon, 30 Sep 2024 15:16:59 +0800	[thread overview]
Message-ID: <c566bff1-b209-9660-2837-9d3b8fca3fb6@huawei.com> (raw)
In-Reply-To: <20240927201755.6402ed04@rorschach.local.home>



在 2024/9/28 8:17, Steven Rostedt 写道:
> On Thu, 12 Sep 2024 11:15:50 +0000
> Liao Chang <liaochang1@huawei.com> wrote:
> 
>> This patch uses [first ... last] = value to initialize fgraph_array[].
>> And it declares all the callbacks in fgraph_stub as static, as they are
>> not called from external code.
> 
> This patch doesn't look like a simplification, and it is incorrect
> about the "not called from external code" as the kernel test robot
> pointed out!

Yes, I overlooked the external call, the static keyword is removed
in the next revision. The patch just makes code neat, it isn't a real
simplification.

> 
> -- Steve
> 

-- 
BR
Liao, Chang

      reply	other threads:[~2024-09-30  7:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 11:15 Liao Chang
2024-09-13 20:10 ` kernel test robot
2024-09-28  0:17 ` Steven Rostedt
2024-09-30  7:16   ` Liao, Chang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c566bff1-b209-9660-2837-9d3b8fca3fb6@huawei.com \
    --to=liaochang1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®