mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Linus Walleij <linus.walleij@linaro.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	Srinivas Neeli <srinivas.neeli@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 1/3] gpio: xilinx: drop dependency on GPIO_OF
Date: Tue, 1 Oct 2024 12:30:13 +0200	[thread overview]
Message-ID: <c56f17e9-8da2-4894-9000-b74b7cb66e86@amd.com> (raw)
In-Reply-To: <20240930144804.75068-1-brgl@bgdev.pl>



On 9/30/24 16:48, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> This driver doesn't really depend on gpiolib-of being built and can be
> compiled without it.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>   drivers/gpio/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index d93cd4f722b4..0d676c96b72d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -796,7 +796,6 @@ config GPIO_XGENE_SB
>   config GPIO_XILINX
>   	tristate "Xilinx GPIO support"
>   	select GPIOLIB_IRQCHIP
> -	depends on OF_GPIO
>   	help
>   	  Say yes here to support the Xilinx FPGA GPIO device.
>   

The patch itself is fine but it should be likely applied as last one not the 
first one.
If this is applied like that feel free to add

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

  parent reply	other threads:[~2024-10-01 10:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 14:48 Bartosz Golaszewski
2024-09-30 14:48 ` [PATCH 2/3] gpio: xilinx: use helper variable to store the address of pdev->dev Bartosz Golaszewski
2024-10-01 10:28   ` Michal Simek
2024-10-02 13:19   ` Linus Walleij
2024-09-30 14:48 ` [PATCH 3/3] gpio: xilinx: use generic device properties Bartosz Golaszewski
2024-10-01 10:29   ` Michal Simek
2024-10-02 13:20   ` Linus Walleij
2024-10-01 10:30 ` Michal Simek [this message]
2024-10-01 10:44   ` [PATCH 1/3] gpio: xilinx: drop dependency on GPIO_OF Bartosz Golaszewski
2024-10-01 11:13     ` Michal Simek
2024-10-01 12:31       ` Bartosz Golaszewski
2024-10-02 14:34         ` Bartosz Golaszewski
2024-10-08  8:18 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c56f17e9-8da2-4894-9000-b74b7cb66e86@amd.com \
    --to=michal.simek@amd.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=srinivas.neeli@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®