From: Jeff Layton <jlayton@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: [GIT PULL] Ceph fixes for 5.1-rc7
Date: Sun, 28 Apr 2019 12:18:00 -0400 [thread overview]
Message-ID: <c570c901c850b6308bc78fcc6c7308f0bc491cb1.camel@kernel.org> (raw)
In-Reply-To: <20190428155216.GB23075@ZenIV.linux.org.uk>
On Sun, 2019-04-28 at 16:52 +0100, Al Viro wrote:
> On Sun, Apr 28, 2019 at 11:47:58AM -0400, Jeff Layton wrote:
>
> > We could stick that in ceph_dentry_info (->d_fsdata). We have a flags
> > field in there already.
>
> Yes, but... You have it freed in ->d_release(), AFAICS, and without
> any delays. So lockless accesses will be trouble.
That's easy enough to fix -- we could add a rcu_head to it and call_rcu
in ceph_d_release instead of just freeing it immediately.
I guess if we find that d_fsdata is NULL, we can just treat it like we
currently do a negative dentry?
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2019-04-28 16:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 17:47 Ilya Dryomov
2019-04-25 18:02 ` Linus Torvalds
2019-04-25 18:21 ` Al Viro
2019-04-25 18:24 ` Linus Torvalds
2019-04-25 18:31 ` Al Viro
2019-04-25 18:36 ` Jeff Layton
2019-04-25 18:23 ` Jeff Layton
2019-04-25 20:09 ` Al Viro
2019-04-26 16:25 ` Jeff Layton
2019-04-26 16:36 ` Linus Torvalds
2019-04-26 16:43 ` Linus Torvalds
2019-04-26 17:01 ` Al Viro
2019-04-26 17:08 ` Linus Torvalds
2019-04-26 17:11 ` Al Viro
2019-04-26 20:49 ` Jeff Layton
2019-04-26 21:28 ` Al Viro
2019-04-26 16:50 ` Al Viro
2019-04-26 17:30 ` Jeff Layton
2019-04-28 4:38 ` Al Viro
2019-04-28 13:27 ` Jeff Layton
2019-04-28 14:48 ` Al Viro
2019-04-28 15:47 ` Jeff Layton
2019-04-28 15:52 ` Al Viro
2019-04-28 16:18 ` Jeff Layton [this message]
2019-04-28 16:40 ` Al Viro
2019-04-25 18:35 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c570c901c850b6308bc78fcc6c7308f0bc491cb1.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®