From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 930D7C433FE for ; Mon, 31 Jan 2022 13:53:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377301AbiAaNx5 (ORCPT ); Mon, 31 Jan 2022 08:53:57 -0500 Received: from mga17.intel.com ([192.55.52.151]:7957 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232774AbiAaNx4 (ORCPT ); Mon, 31 Jan 2022 08:53:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643637236; x=1675173236; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=AEaiGMVj7unyqE7VbRmUuqcbF86FB7Qs3mepDVHeyeU=; b=h0P2hU0knm3eJLXavKEaJHC+qsjFw518ImSKH3XXc1GSOov6bJ4O4Ur5 wPyWxcfSluoff5sAmKo55dA+g8X5VRjoa7cJb1L/KcOp2dXbOuZTNausR ChZwEx3jtQ57E6yQINP5wY/YOjLYPImlWKGBgMwSbTqQWy8IwYw3sHURV aASJdQs7A7qB04ZIa0sxxEid08e2xYfw16moLz4BCyYs7LH2dujx6BoxB uvHP5GgNdHuwWAg51qltZXJJhPzLvChkTQjbvWrsu+5pFg0RnZG/RqrP5 FsQIN1KTUaGLameQtwMilyHLTyEXmk/qejbxuGKM94uLEWE31T1Xo7j5C g==; X-IronPort-AV: E=McAfee;i="6200,9189,10243"; a="228124509" X-IronPort-AV: E=Sophos;i="5.88,331,1635231600"; d="scan'208";a="228124509" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2022 05:53:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,331,1635231600"; d="scan'208";a="619385285" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jan 2022 05:53:55 -0800 Received: from [10.209.18.139] (kliang2-MOBL.ccr.corp.intel.com [10.209.18.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id A3D1C5809EB; Mon, 31 Jan 2022 05:53:53 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 08:53:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 03/26] perf vendor events: Update metrics for Broadwell DE Content-Language: en-US To: Ian Rogers , Zhengjun Xing , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Maxime Coquelin , Alexandre Torgue , Andi Kleen , James Clark , John Garry , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian References: <20220129080929.837293-1-irogers@google.com> <20220129080929.837293-4-irogers@google.com> From: "Liang, Kan" In-Reply-To: <20220129080929.837293-4-irogers@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/29/2022 3:09 AM, Ian Rogers wrote: > Based on TMA_metrics-full.csv version 4.3 at 01.org: > https://download.01.org/perfmon/ > Events are still at version 7: > https://download.01.org/perfmon/BDW-DE > Json files generated by: > https://github.com/intel/event-converter-for-linux-perf > > This adds TopdownL1_SMT metrics to bdwde-metrics.json as > generated by the extract-tmam.py script. > > Tested: > ... > 6: Parse event definition strings : Ok > 7: Simple expression parser : Ok > ... > 9: Parse perf pmu format : Ok > 10: PMU events : > 10.1: PMU event table sanity : Ok > 10.2: PMU event map aliases : Ok > 10.3: Parsing of PMU event table metrics : Skip (some metrics failed) > 10.4: Parsing of PMU event table metrics with fake PMUs : Ok > ... > 68: Parse and process metrics : Ok > ... > 88: perf stat metrics (shadow stat) test : Ok > 89: perf all metricgroups test : FAILED! > 90: perf all metrics test : FAILED! > 91: perf all PMU test : Ok > ... > The failures/skips relate to: > event syntax error: '{arb/event=0x84,umask=0x1,metric-id=arb!3event!20x84!0umask!20x1!3/,arb/even..' > \___ Cannot find PMU `arb'. Missing kernel support? > ARB is an uncore unit for client platforms. Broadwell DE should be a server platform. It looks like an issue of TMA_metrics-full.csv. I will check and see whether we can fix the TMA file. Thanks, Kan > Signed-off-by: Ian Rogers > --- > .../arch/x86/broadwellde/bdwde-metrics.json | 401 +++- > .../arch/x86/broadwellde/cache.json | 1122 +++++----- > .../arch/x86/broadwellde/floating-point.json | 222 +- > .../arch/x86/broadwellde/frontend.json | 335 +-- > .../arch/x86/broadwellde/memory.json | 608 +++--- > .../arch/x86/broadwellde/other.json | 28 +- > .../arch/x86/broadwellde/pipeline.json | 1892 ++++++++--------- > .../arch/x86/broadwellde/virtual-memory.json | 394 ++-- > 8 files changed, 2646 insertions(+), 2356 deletions(-)