From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12C8B435526 for ; Mon, 10 Aug 2026 18:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385620; cv=none; b=qR0ymNI8YhY/sDyrh3q377eZG10YI8df1A4QEpVxMgU0IlMQQhg2G2iLz5f5GkeNoEg30ryplTcZelsTd7GpHMr9ygeipdCQdwTi1eLC3zE5qndoh1JFqtSBIyxlt/pV54Wt94HHB9Duf4jQxa5I8TDn5lp7ihokcvKqrK+UaUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385620; c=relaxed/simple; bh=LxqzrTJv5Eqx3zrr8cQAwC8hTp+RGnUBOHgB8lVvAQw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=chQj1Gf+ZCHyP7LYxJwKJtoPL1uGBQohzLktww0qHbLjltUu82uzF+PAOhEb0yArMvbeTgMLS+ftffmiLYXJZ6/SFpqMaaTpM9LVQrLFY4YgNYjzqNL5M/KLS0I+B0VTKv1mrdeMWurG3vQu5ZD35FimAuiCg6r6hyaNFaBuNnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QVgnK1NT; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QVgnK1NT" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38e041ea211so2538823a91.0 for ; Mon, 10 Aug 2026 11:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385618; x=1786990418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jUm5zg635IdCfrd8nRe9kr7IONoPkdCFzJRsBETaklg=; b=QVgnK1NTnbE75IvaAwReUBn/f7Wet+iX690147bgGdoPwm1Hq2oOkHpB02YPEjrP9I iTdx9WCRHBZmpk/kQBDT2zWmYj1fWjw/aLkTOsW4NIKXP7l2ZduMzStIyfKnjl5KcYuJ 0+CgVjb7N9Rh9lsRyy0YJ0wb5NoOQ/6CvQCH2WFG1Q62RItrcvViha/twwURJOPXvt/A i5tzplxHtJwyFYNIm8kidFKhlun7O2NJeRv55uTn4sTD2N03WsBmvbGdq7L9yLd0lkmF VfVEZA3aHRNQ1RxBZf9v2m3Q0anEffhdEd5j8cLdcHUZRfuvz3njNxWNXdVwI9ens7WT +t4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385618; x=1786990418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jUm5zg635IdCfrd8nRe9kr7IONoPkdCFzJRsBETaklg=; b=h4CnFJ1oxGvxnJvywBTlYKdfjcJBxO0pbftjRHU1mhT9g9dJajogOQWeYYddRdyvli X/GhJYT0RMZvt9Bd6HBoiqw/gOXCQ2Fv5hAomzlF+VvJMvE0ASn9TQXMOq//YrFccifg mgaD+xPHHBGhJZO5TLDW9NylTtSxnwPIT1KXWiDz64lV3PM1N+RTExIk9fzCqhZRstOv TpViEQ3NB48FkO5+3AIlR6Cj3pT8g2BFvBEcwwzOu0I/J8wlpelOmUlpZ93vzHrjLNHj VPSnExD2/DGqVZvrhLqplk/oYaur0S/xudb26bEqyQlvVXToNFQoHpbvuHyC7YPewNGx h8cQ== X-Forwarded-Encrypted: i=1; AHgh+RpBKu4JjjzLDVLghkAIyzMJZvDfLNvFeaPjyYPJXLK7CqIzk3iWzp87GsnIcDjClu0PrIPBuj6CpOIRAlA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzim+yRCW16z1HlF9fDsPp7Dw7kOVUjdCs5+5i2sGZ4EgV3PESj QKC8ESRyvBAs1upSfVHesYoZsUywsp+MCehyFuF/Icxjio2ZfWF5yGC2 X-Gm-Gg: AR+sD10by7IKUD4a8j1dixFY6GiibD46O2gSQ5Ue8JXlnC3nrJxG9v4B1VE362lAsGY W7vMiLhekKF73vOw+Sr9J+i6g1nJtIjbUr4b+EifSOkPZ3hk3BJNxwu7pStp09Qx6wd11qt2WgP +HSmv50qZDlxqbMrgtYvHLV7/kGonC0DJ5xhCaPl1H8T8vQ0GVWYYH2tc0XBJYx2GVs6Lj87ov6 T+2YX4YmC54wU8sTm2MG5WJhHR9On9g1TZ38BKMDTDKM4CRBilGdxqgurXQxD7/LncUpxuSFvdJ k+E6ItlbtOBstzYewcBHXYyeuIbJ2TAync2tsfCsnbLxMEyeb3yKmfaGRuayvLxTX6Zu3yCSrzX GbTR5NHeeIlZPD4i1Ht5va+/6cxIwXPgKrOvDLylnqwyBLqFRJfv2+BWiMtaJwPV+wKZuXU9Wlw 7R1r/HOGeuLZSDfxZMSZJawrWHeccd1d8lHhZzAQFxt6AyQAMCCwZJJkcCbe0cg0R9Ol0RHtzuw A== X-Received: by 2002:a17:90b:2785:b0:38e:bbf1:de3f with SMTP id 98e67ed59e1d1-3903c5d2f29mr48647797a91.12.1786385618336; Mon, 10 Aug 2026 11:13:38 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:13:37 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Dmitry Baryshkov , Miaoqian Lin , Jyothi Kumar Seerapu , Icenowy Zheng , linux-arm-msm@vger.kernel.org Subject: [PATCH v3 33/34] dmaengine: qcom-gpi: defer callbacks via vchan Date: Mon, 10 Aug 2026 11:09:34 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Complete descriptors through virt-dma instead of invoking callbacks directly from event processing. This preserves the transfer result for the shared vchan BH, which invokes the callback and frees the descriptor; drain that BH before releasing channel resources. Signed-off-by: Allen Pais --- drivers/dma/qcom/gpi.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index a5055a6273af..2bc3a07ef092 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -981,8 +981,12 @@ static void gpi_process_imed_data_event(struct gchan *gchan, result.result = DMA_TRANS_NOERROR; result.residue = gpi_desc->len - imed_event->length; - dma_cookie_complete(&vd->tx); - dmaengine_desc_get_callback_invoke(&vd->tx, &result); + spin_lock_irqsave(&gchan->vc.lock, flags); + list_del(&vd->node); + vd->tx_result = result; + vchan_cookie_complete(vd); + spin_unlock_irqrestore(&gchan->vc.lock, flags); + return; gpi_free_desc: spin_lock_irqsave(&gchan->vc.lock, flags); @@ -1060,8 +1064,12 @@ static void gpi_process_xfer_compl_event(struct gchan *gchan, result.residue = gpi_desc->len - compl_event->length; dev_dbg(gpii->gpi_dev->dev, "Residue %d\n", result.residue); - dma_cookie_complete(&vd->tx); - dmaengine_desc_get_callback_invoke(&vd->tx, &result); + spin_lock_irqsave(&gchan->vc.lock, flags); + list_del(&vd->node); + vd->tx_result = result; + vchan_cookie_complete(vd); + spin_unlock_irqrestore(&gchan->vc.lock, flags); + return; gpi_free_desc: spin_lock_irqsave(&gchan->vc.lock, flags); @@ -2009,6 +2017,7 @@ static void gpi_free_chan_resources(struct dma_chan *chan) /* free all allocated memory */ gpi_free_ring(&gchan->ch_ring, gpii); + dmaengine_kill_bh(&gchan->vc.chan); vchan_free_chan_resources(&gchan->vc); kfree(gchan->config); -- 2.43.0