From: Yisheng Xie <xieyisheng1@huawei.com>
To: Matt Fleming <matt@codeblueprint.co.uk>,
Will Deacon <will.deacon@arm.com>
Cc: <mingo@kernel.org>, <guohanjun@huawei.com>,
<mark.rutland@arm.com>, <catalin.marinas@arm.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>, <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] arm64/efi: efi_init error handling fix
Date: Wed, 7 Sep 2016 19:15:48 +0800 [thread overview]
Message-ID: <c57dfbbe-a2a7-e8af-7d94-20f86126053c@huawei.com> (raw)
In-Reply-To: <20160905135723.GK32579@codeblueprint.co.uk>
On 2016/9/5 21:57, Matt Fleming wrote:
> On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
>> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
>>> From: Yisheng Xie <xieyisheng1@huawei.com>
>>>
>>> diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
>>> index c49d50e..5080e40 100644
>>> --- a/drivers/firmware/efi/arm-init.c
>>> +++ b/drivers/firmware/efi/arm-init.c
>>> @@ -243,8 +243,10 @@ void __init efi_init(void)
>>> "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
>>> efi.memmap.desc_version);
>>>
>>> - if (uefi_init() < 0)
>>> + if (uefi_init() < 0) {
>>> + early_memunmap(efi.memmap.map, params.mmap_size);
>>> return;
>>> + }
>
> This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
> flag also needs clearing.
>
Hi Matt,
Thanks for your reply.
You mean call the function efi_unmap_memmap() like x86?
however, it seems no need to clear EFI_MEMMAP here. For arm*, the flag
EFI_MEMMAP is set in function reserve_regions(), which is called
only when uefi_init() return 0:
efi_init()
-> reserve_regions()
-> set_bit(EFI_MEMMAP, &efi.flags);
Thanks
Xie Yisheng.
> .
>
next prev parent reply other threads:[~2016-09-07 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 10:18 Xie Yisheng
2016-09-02 10:26 ` Will Deacon
2016-09-05 11:11 ` Yisheng Xie
2016-09-05 13:57 ` Matt Fleming
2016-09-07 11:15 ` Yisheng Xie [this message]
2016-09-13 11:18 ` Matt Fleming
2016-09-19 12:29 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c57dfbbe-a2a7-e8af-7d94-20f86126053c@huawei.com \
--to=xieyisheng1@huawei.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=guohanjun@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®