From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbdGZPXn (ORCPT ); Wed, 26 Jul 2017 11:23:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56126 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbdGZPXl (ORCPT ); Wed, 26 Jul 2017 11:23:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 565E2C0EF9D9 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [RFC/RFT PATCH] KVM: nVMX: fixes to nested virt interrupt injection To: Jim Mattson Cc: LKML , kvm list , Wanpeng Li References: <1500906015-31784-1-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 26 Jul 2017 17:23:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 26 Jul 2017 15:23:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/07/2017 16:55, Jim Mattson wrote: > Hmmm. That field isn't writable on all microarchitectures. You're right... I'll see if there's a simple workaround, or it requires to rework reflection of EXCEPTION_NMI vmexits. The latter would fix PFEC_MASK/MATCH, too... Paolo > On Wed, Jul 26, 2017 at 7:48 AM, Paolo Bonzini > wrote: > > On 25/07/2017 23:08, Jim Mattson wrote: > > > > + > > + if (vcpu->arch.exception.has_error_code) { > > + vmcs_write32(VM_EXIT_INTR_ERROR_CODE, > > vcpu->arch.exception.error_code); > > > > > > Should this be vmcs12->vm_exit_intr_error_code > > = vcpu->arch.exception.error_code? > > No, this writes to the vmcs02 and prepare_vmcs12 copies it to the > vmcs12. > > Paolo > >