From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14789C35247 for ; Wed, 5 Feb 2020 01:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7C832082E for ; Wed, 5 Feb 2020 01:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbgBEB5q convert rfc822-to-8bit (ORCPT ); Tue, 4 Feb 2020 20:57:46 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:2939 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727140AbgBEB5q (ORCPT ); Tue, 4 Feb 2020 20:57:46 -0500 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 32A5CAB5CA5AADBE51FF; Wed, 5 Feb 2020 09:57:44 +0800 (CST) Received: from dggeme714-chm.china.huawei.com (10.1.199.110) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 09:57:43 +0800 Received: from dggeme763-chm.china.huawei.com (10.3.19.109) by dggeme714-chm.china.huawei.com (10.1.199.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 5 Feb 2020 09:57:43 +0800 Received: from dggeme763-chm.china.huawei.com ([10.6.66.36]) by dggeme763-chm.china.huawei.com ([10.6.66.36]) with mapi id 15.01.1713.004; Wed, 5 Feb 2020 09:57:43 +0800 From: linmiaohe To: Sean Christopherson CC: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load_cr3() Thread-Topic: [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load_cr3() Thread-Index: AdXbxp75aDxUWE75SIe9flCE+/wfCA== Date: Wed, 5 Feb 2020 01:57:43 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.221.158] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean Christopherson writes: > The blurb pertaining to the return value of nested_vmx_load_cr3() no longer matches reality, remove it entirely as the behavior it is attempting to document is quite obvious when reading the actual code. > > Signed-off-by: Sean Christopherson > - * Returns 0 on success, 1 on failure. Invalid state exit qualification code > - * is assigned to entry_failure_code on failure. > */ > static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool nested_ept, > u32 *entry_failure_code) It seems the comment is uncorrect as it return -EINVAL on failure. Thanks. Reviewed-by: Miaohe Lin