From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D3E22C08A1 for ; Mon, 16 Feb 2026 16:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771258449; cv=none; b=ZcDTEfTkUcws+sl3/VTvynYkrXuKgztjiBiD4r/T0mjZSX0Yeq2mKhy4QaEhArYHABo12zLUfyuPhHqI7itGzIHmBuFhcAA/G99hq5frPtlTU5tC8mKc0fwinbabxqPiBlDVDLDokvQSXjbuZn9kI/lgGv0fE0wEukkOJuukBOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771258449; c=relaxed/simple; bh=+Rf2uf2zsolAC6ztiZweAMtMnW8/RlmNGg3Byb71wNo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ou8QaMPBf6oMOTYoY38rL0lIhQILT7Y6cxIyCVeKuBeXh13OwGRFTgMm8MR3uc7uBp/LfTBTfAonLIh4lHyeU9ISQa/2eke3hF4nIFggTReaaJ6NwpL+/IlujeWSKPvHm/22QSFI0la4nRexp/NSkpn9ehG5eLTY56zY/0qV50w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QVnTwQFJ; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QVnTwQFJ" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-436309f1ad7so2744847f8f.3 for ; Mon, 16 Feb 2026 08:14:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771258447; x=1771863247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=0ben+fYxU9x35Dz6yHbOIsof6+Krn5+skByxyeCmdbY=; b=QVnTwQFJ39k9Ihj6AfZeTfyd/yl9XOonGkTrM0i646VTfejnQ6d3V3pHmbj/2BNA0h yXlHMNBFytc6fT5J9F9hf6V2NopcxBUKhQgt6S0ohozEC5sjnK7xlb5QhWS/ap2oY/yD KJryMOmRrl0wxdqwAoMHLhGUbEejYpGhdYDOGYMNXsg0xkorRFcgJOQOWe+EA4x4LYcP v6fPXmNpPX7miAzvVfFjFVr2rShQgaerDsnS2avLk0NaLSv1t8xa/3uE/LMEe1SwslWv fLM56xD1Xi1KQuqlLfWDxOugviO6luQ6s/evR8+ve8pQHcJbXTAx+GHZV4YtCsopG6AW /jYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771258447; x=1771863247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ben+fYxU9x35Dz6yHbOIsof6+Krn5+skByxyeCmdbY=; b=T5pBH77uBHNO4AJP0lZ/Eu57+bAEfnC9uTgpCvzU+AdX06ursj7mh9jJ3ltZ9pFCWZ peQN/wxRov+SSasWcyTjQbEqpW3XzVMAXAq0GhbZcOSSP/WeHER9eIe6F5bl71MMRibs tc2MWf/26q67ts6bLcy5Ch3X2foZnvWV8Ko+zNqoCF5vy8rsXlupJgMx3zmyo/euc2eE DvFbdZ5B5o6Z2jSS0uq9uSjhru9B6WZ2J5+YK/oWeNXp6rYyXMcv1NzWazyx68IeI40z wzpWkqcrtm1pRDGc4eqAmIBOaOnSzUO8izLOlyzKCLiw1HWOgO0QOURfnU/XT+UGuQuU KkhQ== X-Forwarded-Encrypted: i=1; AJvYcCUk68lnCtLoS2uQfuEzM5KBX8KIKBsYieJRGTgmwstOnj7ocfdbP8FmGzVqLwIhSGynoPz6PUkVXJrTHD0=@vger.kernel.org X-Gm-Message-State: AOJu0YwKgdkLf+6C3x7THqBDwkVzQpmnB2q9Lcg6Wel9q3i34Pnr3smz do4yiIxlKb9zfbyQ11F//TlKEiXgT+6iUBZM1dAdazE+PUHWKKUggHgX7IQMZykhOck= X-Gm-Gg: AZuq6aLNmcWr+Avesr2Md9t3uGY24QKKMolGOf+UCkuXbjUETCQccMQ+9HbeKDcbv4B 9YvdxI+nTwvuv7bzmuEnSYpKIF5DFjYPY91E48zVmy0mr5yzzZxP6VOqf2AFpIR79x7dDxhlGTi MwCWWEruScyW+iVnTOhf1Ly1gdWmsPPJ1qzaZm2Lkki/EIAfnBCsmfTzrjx8MtnMOBrkTODVq7X 2SkLgdA6oQmUBiPjEWmr9tHsEvAJXnHLCgd2gjCSwfU15ll+/qKv9T81D04lI+wmpzmoFDag9BB A3wo83YyK3SjgSUn9TmriTar8cVe/v4Z6ProGp8glRMBNYWbz63LPpL+TJ95g9G4BfDgSZN0Qnu 7BimcPQn4fNegydx4M+IumgOOo5f1sJUB8RVNm1YGILpoanyQAwyELwGMMGm1ksEFsr5hFO0bSq X0qmIMlVixjQlmI9lyZilObvcVHdy6hSI5LwcrjnUsjgUeVZglXhv+ecyJjioPBxUGKCBBd2X0H Cdjiw== X-Received: by 2002:a05:6000:4310:b0:437:719d:a753 with SMTP id ffacd0b85a97d-4379db3414bmr16542788f8f.11.1771258446468; Mon, 16 Feb 2026 08:14:06 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:80b4:8b51:72a6:9e2a? ([2a01:e0a:106d:1080:80b4:8b51:72a6:9e2a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a6a5f0sm27482504f8f.11.2026.02.16.08.14.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Feb 2026 08:14:06 -0800 (PST) Message-ID: Date: Mon, 16 Feb 2026 17:14:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v1 2/5] drm/panel: r61307/r69328: convert to drm_connector_helper_get_modes_fixed To: Svyatoslav Ryhel , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260215085140.20499-1-clamor95@gmail.com> <20260215085140.20499-3-clamor95@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260215085140.20499-3-clamor95@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/15/26 09:51, Svyatoslav Ryhel wrote: > Switch to use of drm_connector_helper_get_modes_fixed helper for get_modes > operation. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/gpu/drm/panel/Kconfig | 2 ++ > drivers/gpu/drm/panel/panel-renesas-r61307.c | 17 +++-------------- > drivers/gpu/drm/panel/panel-renesas-r69328.c | 17 +++-------------- > 3 files changed, 8 insertions(+), 28 deletions(-) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 477c54c90b01..47de5f6a9143 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -700,6 +700,7 @@ config DRM_PANEL_RENESAS_R61307 > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > + select VIDEOMODE_HELPERS > help > Say Y here if you want to enable support for KOE tx13d100vm0eaa > IPS-LCD module with Renesas R69328 IC. The panel has a 1024x768 > @@ -713,6 +714,7 @@ config DRM_PANEL_RENESAS_R69328 > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > + select VIDEOMODE_HELPERS > help > Say Y here if you want to enable support for JDI dx12d100vm0eaa > IPS-LCD module with Renesas R69328 IC. The panel has a 720x1280 > diff --git a/drivers/gpu/drm/panel/panel-renesas-r61307.c b/drivers/gpu/drm/panel/panel-renesas-r61307.c > index 873ef856184b..45afa44af114 100644 > --- a/drivers/gpu/drm/panel/panel-renesas-r61307.c > +++ b/drivers/gpu/drm/panel/panel-renesas-r61307.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define R61307_MACP 0xb0 /* Manufacturer CMD Protect */ > #define R61307_MACP_ON 0x03 > @@ -202,25 +203,13 @@ static const struct drm_display_mode renesas_r61307_mode = { > .vtotal = 1024 + 24 + 8 + 2, > .width_mm = 76, > .height_mm = 101, > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > }; > > static int renesas_r61307_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > - struct drm_display_mode *mode; > - > - mode = drm_mode_duplicate(connector->dev, &renesas_r61307_mode); > - if (!mode) > - return -ENOMEM; > - > - drm_mode_set_name(mode); > - > - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > - connector->display_info.width_mm = mode->width_mm; > - connector->display_info.height_mm = mode->height_mm; > - drm_mode_probed_add(connector, mode); > - > - return 1; > + return drm_connector_helper_get_modes_fixed(connector, &renesas_r61307_mode); > } > > static const struct drm_panel_funcs renesas_r61307_panel_funcs = { > diff --git a/drivers/gpu/drm/panel/panel-renesas-r69328.c b/drivers/gpu/drm/panel/panel-renesas-r69328.c > index 46287ab04c30..b40bfd702fac 100644 > --- a/drivers/gpu/drm/panel/panel-renesas-r69328.c > +++ b/drivers/gpu/drm/panel/panel-renesas-r69328.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define R69328_MACP 0xb0 /* Manufacturer Access CMD Protect */ > #define R69328_MACP_ON 0x03 > @@ -167,25 +168,13 @@ static const struct drm_display_mode renesas_r69328_mode = { > .vtotal = 1280 + 6 + 3 + 1, > .width_mm = 59, > .height_mm = 105, > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > }; > > static int renesas_r69328_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > - struct drm_display_mode *mode; > - > - mode = drm_mode_duplicate(connector->dev, &renesas_r69328_mode); > - if (!mode) > - return -ENOMEM; > - > - drm_mode_set_name(mode); > - > - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > - connector->display_info.width_mm = mode->width_mm; > - connector->display_info.height_mm = mode->height_mm; > - drm_mode_probed_add(connector, mode); > - > - return 1; > + return drm_connector_helper_get_modes_fixed(connector, &renesas_r69328_mode); > } > > static const struct drm_panel_funcs renesas_r69328_panel_funcs = { Reviewed-by: Neil Armstrong Thanks, Neil