From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751472AbdAQXWq (ORCPT ); Tue, 17 Jan 2017 18:22:46 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36836 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbdAQXWn (ORCPT ); Tue, 17 Jan 2017 18:22:43 -0500 Subject: Re: [PATCH v2 1/3] xen: clean up xenbus internal headers To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170116141533.8946-1-jgross@suse.com> <20170116141533.8946-2-jgross@suse.com> From: Boris Ostrovsky Message-ID: Date: Tue, 17 Jan 2017 18:21:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170116141533.8946-2-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/16/2017 09:15 AM, Juergen Gross wrote: > The xenbus driver has an awful mixture of internally and globally > visible headers: some of the internally used only stuff is defined in > the global header include/xen/xenbus.h while some stuff defined in > internal headers is used by other drivers, too. > > Clean this up by moving the externally used symbols to > include/xen/xenbus.h and the symbols used internally only to a new > header drivers/xen/xenbus/xenbus.h replacing xenbus_comms.h and > xenbus_probe.h > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky