From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486A734A3D2; Fri, 13 Feb 2026 09:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975321; cv=none; b=jVoiv2hTd0TGyPN10GGml8FVx73aR/ne8fLpF+gtmBjAebqSSFygDt+pkDOM9S6uL43bntcmWT4bNBfbNqzm7NsrEf8i6Z64oFhQumF5ERRR7t6naGtHTNNZ68FIFFlsnDouWbWhosRLT1PstmZl+iMtg2qir2uitFtqnp7SZa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770975321; c=relaxed/simple; bh=f9czAYBnY4F1mb2qB92X9nU6lRz+eaOYt/gVPcytyK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tyX4zgKvhiyKM+GHmPdrL/DFzP3qIvtRa45aHjgE19RbJRybpv0/XVYB+9W/+MY4DBwlpOdgCVi6jw4HsUTvIx3FRlJ3GTEXOfmU/dBJwhGj6zONNNZncgnPOoSDXOS4OOi3MsKSAEv9uoQTdOFrMQVFG+FgPhB/T/EW0g6HkVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=WF6UIG1L; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="WF6UIG1L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770975318; bh=f9czAYBnY4F1mb2qB92X9nU6lRz+eaOYt/gVPcytyK4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WF6UIG1L/DlR4lhHsHYVWBoyIIbWGoqF7Za+PgATHTvvIW7tKTp5QLlfltd4S0alo 8yYP9PCnSjAjrbpuP/8PWMnSCOCNLqRresRVB2pO8Ac4I+qo92a5czKysIEBmAnRh6 qGqVUPNYVcvE8YrLf4Cumf4MqgQL7i2ki6ZHOFna+ETtfye5KfEamjqH9VeVunrJUi rOsqxyFxPzE00DR0b7DzFJ5CsAWc4yZMDEMhxDduR9CbSF8CLVAe2dtA8MNh+4gbfv J/gkLKVBtwgEJSKNKu7iW3ZM1SwmKWjLmU9R3OrPH/zs7TrnrNaMiph0OUx4HaKvj9 M4XzZzruB0zRw== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 019B217E00AC; Fri, 13 Feb 2026 10:35:17 +0100 (CET) Message-ID: Date: Fri, 13 Feb 2026 10:35:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] media: synopsys: only check errors from devm_clk_bulk_get_all() To: Frank Li , Mauro Carvalho Chehab , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Guoniu Zhou , Laurent Pinchart , imx@lists.linux.dev References: <20260210-imx93-dw-csi2-v1-0-69667bb86bfa@nxp.com> <20260210-imx93-dw-csi2-v1-2-69667bb86bfa@nxp.com> Content-Language: en-US From: Michael Riesch In-Reply-To: <20260210-imx93-dw-csi2-v1-2-69667bb86bfa@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Frank, Thanks for your patch. The remark w.r.t. the "media: synopsys: csi2rx: " prefix holds for this and all the other patches in this series as well, of course. On 2/10/26 18:11, Frank Li wrote: > devm_clk_bulk_get_all() returns all clocks described in the DT, which are > already validated by the binding. Do not need enforce an expected clock > count. > > Only check for error returns (< 0) to support more SoCs. > > Signed-off-by: Frank Li > --- > drivers/media/platform/synopsys/dw-mipi-csi2rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c > index 0cc892f4a1b3c6ce575a5d4fca7acf7057f7b7f7..61cd7f491b3d5b8a37707b23ca03ce709b40a79f 100644 > --- a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c > +++ b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c > @@ -630,7 +630,7 @@ static int dw_mipi_csi2rx_probe(struct platform_device *pdev) > return PTR_ERR(csi2->base_addr); > > ret = devm_clk_bulk_get_all(dev, &csi2->clks); > - if (ret != DW_MIPI_CSI2RX_CLKS_MAX) DW_MIPI_CSI2RX_CLKS_MAX is not used anymore, please remove. With that change, Reviewed-by: Michael Riesch Best regards, Michael > + if (ret < 0) > return dev_err_probe(dev, -ENODEV, "failed to get clocks\n"); > csi2->clks_num = ret; > >