From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C273274FE8 for ; Wed, 11 Mar 2026 12:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773233276; cv=none; b=P/5smc60ZUpMENLYoljIDb7gO35eWiulEJ6pZbltqgiQWb85Mr4NDBVPk8M2gOlaMbz7vXbLaAOyGp0Qzj5ZebkqNH58QCYU1oGPel7469ZLrlRdunNRVv+HQdVNtk9bHpZSNa2jpg8rgr/mLYfHNtgxq0aNY7aqnbfhuSeqiN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773233276; c=relaxed/simple; bh=1Psjk2nRaHfHDd8xvc4KgUjjkgHuvgedYWJ7MpRosLU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nXRAl6/gngE3scMu4xd+DIs6cs7z6/oRikkW9EODVVp+K5tsbwj//noF6EsdKi/mKaxkRYQshsdWm6PkIwHtA5iMN6qNjrJ/VI/VPm6JEEQjml4pJ8O+Ax9cA9H5WHeJ3kTr+F92xa+pWOxPnc0mlAr83YpZOl9/siqG8aCDWjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CEFaIkWP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HvwrFhwK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CEFaIkWP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HvwrFhwK" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B8aslt248813 for ; Wed, 11 Mar 2026 12:47:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +Y2CHFwj1sgN4QWWRsY4MppwS3vloHKyBvjpPhe1hYQ=; b=CEFaIkWPEoRifqNS H8nTnMFU+83FdF3a/oOL7udbSYymg9pyZTKcOXbMqnAenMnvQOf6vbNXhV2FSapA FN7o+TGY2AjtS4rQ85WOsf6sMb/CqWiwsUwxlsfjFEul/cGbf71PXxhllDcrZFsE SURVgac13cHiBsPJIIkKafEMzzqGU2Z/g8ewsQYvtBwEGPDmN3fsoEqcbpy7IEfS ovg4vBcKoTeHKka9Ih778yij9Nu/fJkzEC0VqqOwrFyO117mg7J0UFQFkidtiLTq KYOEd/dNDQgDT5WIxR2FrAU/YHYT1yoBlIUXnE/ncSSNLjDSAT4DFWyLdGCiZp2T NTPsXw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctqv13jw9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 12:47:53 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-899fcb63705so53184156d6.1 for ; Wed, 11 Mar 2026 05:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773233273; x=1773838073; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+Y2CHFwj1sgN4QWWRsY4MppwS3vloHKyBvjpPhe1hYQ=; b=HvwrFhwKCEIfZayOZYk9VLoFFHo564YYR/NzsxxrVVmBk40vXjVirdk+yQlZMIg0yk joajnVzrAabbD4vBFGGIvvfkr+4zps2KQqrXloLKVW4EiMDuBTMbfYZL4jddNYs95HqI lEkWdjFTGOH5hnAaCTBL6SqxZm1QhZagJLfSXwooPOZMmvwqm+3GYZXHkz9xiIECvLbD HECStBrCB9sbJDTOiJMDqwS/7AP5MidVuR8XvWw+uPnVm6U378MFe+fLIn7i6ufFbwBx mJi8INeMBNbBvLgMzOmQ0L/bvq471WJAT68md3BAOaCiED3T3nE8cfqCRw+PIetFQsSR 42FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773233273; x=1773838073; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+Y2CHFwj1sgN4QWWRsY4MppwS3vloHKyBvjpPhe1hYQ=; b=EYI4UoZoEXb27Ur/tFnfT6r32hnwo440jCLkp0JjdnjJKAddO9MqbJfkYu2aGtM0Xt nbXB4dC+u7jElFdBrdKNmeriGEBOEQbtCRbTl9zV1JwRJWwMKpAHBWeGmy8eqEn+iR/t RhnIZdheq76aZHCZol4OMJGp5QfGsEHLjC0JLf+I2h1DyGKpyHr5/yqn7zyxA4WU9D9l pRKGBQkM7iR4xFspbwo8sKFaXXbwLY+Q9crGuOf16bllUitgS3Fncz4JLkVLfpntiC5K 67XTdKAIzMvO7RqRgdyoR//Njf+V8b5mLfOcxaLDMxrM+JuxlO6rHL5SJ+PNYzIGvD26 wDxg== X-Forwarded-Encrypted: i=1; AJvYcCUDjCRAJE0n+sjZed+R2dyssXUVGay6FdpyJLnEVaBRPNhwOKwrue8Tjwek67rx0c/x51OobCMn1T8fPBI=@vger.kernel.org X-Gm-Message-State: AOJu0YxclprGBz64ZzUWo7LalfTH1MO/Y0sWurZl/X0a9mW2atQJO40W 37V7Mf1TrJL/zlKx/Yb55rUglgGwLpxw5mNhKxPauiP7YaInK+yq+7jinF8NgW0nGC8AceOaNhA W0kGTMl/dKzP1k2DPZhNkAF/IF2A1JHm5D7QFue8uk4vYgdnBOzp4DmbMitnlSJViA6M= X-Gm-Gg: ATEYQzyKyhPIrvwnTV4xaD70TEe4PoAN6C1Jne96sONUJEjiXIMCxSvPpPGTNlBJB/o oOLfSFPLaxHAwtgnmcdo1lkDz3jv0juy+X1dCtWBqKb/nt2FJLKQlqDv8wCFx/hpjxzQyiFkyBV wUz4ud8hfFjWA7DLHnvUyRs+9fgObaTR/mhlORCBDY4ruFKyNrkN18/cqmZStFA++eLs+gyCV2j dIZvPN15UjxERUUEhBZywnb8LuZRrxZW44livfiYMlkoyp23tMdiQNba88avWJPQ6ew8iQXMPLx aVmz3OAQI6GuDGcBoAOtA6vhVZapRPb1Rccbci3gnMOEhqEHPqf6UzIbwrGBTAEwcTvMPc6tF3F Hyrx+1dEKr/0WCTV/46CKorLW7rZMx5YbtO/tqBBrPVnGofsOhvV4ry4NwcvlayjaPUyrXILslB edVug= X-Received: by 2002:a05:6214:4c47:b0:89a:5129:510f with SMTP id 6a1803df08f44-89a668804b8mr20351646d6.0.1773233272903; Wed, 11 Mar 2026 05:47:52 -0700 (PDT) X-Received: by 2002:a05:6214:4c47:b0:89a:5129:510f with SMTP id 6a1803df08f44-89a668804b8mr20351296d6.0.1773233272292; Wed, 11 Mar 2026 05:47:52 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b972de4795asm53950266b.18.2026.03.11.05.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 05:47:51 -0700 (PDT) Message-ID: Date: Wed, 11 Mar 2026 13:47:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen To: Dmitry Baryshkov Cc: cristian_ci@protonmail.com, Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260308-rimob-new-features-v1-0-aa2c330572c0@protonmail.com> <20260308-rimob-new-features-v1-5-aa2c330572c0@protonmail.com> <6ddgxby2wzaa7mfbc64a4ld2rdbo6427csw6blzg5alstvkfv3@usfqftgctnzs> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6ddgxby2wzaa7mfbc64a4ld2rdbo6427csw6blzg5alstvkfv3@usfqftgctnzs> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEwOCBTYWx0ZWRfXwpgxQ+oMqrks mJv+0i11W6eJXHKmUrg0cRErSAXhtVOszUK43vm1OEyZTnG/Y5z1lxSXjrN6CpCXI1m8RcolPn5 4QtXiH52prI8r+IGbb9zXgiG66z1LFstJxR5Pvc+3xsFBtNIHleK/rvfWb9gMh86INW3PiqqBQb NjHv5Bb17Va+aWmc77/pN28rI2I4uEH2dUDnJnwDLieKjZkrq/F6NPl8KBmsA2NPMZik0dLby73 L0q98sdTd4oH3I64F1hytGyJXapEhbvIwJsAHVLHNDLStKPregcui3LlqtsqscfJp850FegDkH7 7hFwrjLlaXFGc+pb3fw7gKvuScwGdk0Xb56SKw9LudBEHEfZhJN7lL/5TzDGuewhXO+29uFdHw6 UOrcj24ulr3GJnDneJ3zuR6f1YVDZbr/CZgVU/uHm+6jt7uX6gpmP+3GCO9qfdP76w82l8HRfPT EYeV9w04VFYS9TOEYUQ== X-Proofpoint-GUID: 9hJueEIoh5_1UigWb7ttR098GNEcd5j0 X-Authority-Analysis: v=2.4 cv=S5vUAYsP c=1 sm=1 tr=0 ts=69b16479 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=sfOm8-O8AAAA:8 a=Qi8LA-PbnRB-KSu4gE4A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-ORIG-GUID: 9hJueEIoh5_1UigWb7ttR098GNEcd5j0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110108 On 3/10/26 11:49 PM, Dmitry Baryshkov wrote: > On Tue, Mar 10, 2026 at 02:08:40PM +0100, Konrad Dybcio wrote: >> On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote: >>> From: Cristian Cozzolino >>> >>> This device uses a Goodix GT5688 touch controller, connected to i2c_3. >>> Add it to the device tree. >>> >>> Signed-off-by: Cristian Cozzolino >>> --- >>> .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 ++++++++++++++++++++++ >>> 1 file changed, 32 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>> index 7b2849405462..709ea6fc9fbb 100644 >>> --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>> +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts >>> @@ -94,6 +94,31 @@ &hsusb_phy { >>> status = "okay"; >>> }; >>> >>> +&i2c_3 { >>> + status = "okay"; >>> + >>> + touchscreen@5d { >>> + compatible = "goodix,gt5688"; >>> + reg = <0x5d>; >>> + >>> + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; >> >> interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't >> even consume the former. Trying to read through some of that, I think > > I think you need both, take a look, there are enough users of > ts->gpiod_int. I said irq-gpios was necessary, interrupts is not. The only retrieval happens through: if (soc_intel_is_cht() && ts->gpio_count == 2 && ts->gpio_int_idx != -1) { irq = acpi_dev_gpio_irq_get(ACPI_COMPANION(dev), 0); if (irq > 0 && irq != ts->client->irq) { dev_warn(dev, "Overriding IRQ %d -> %d\n", ts->client->irq, irq); ts->client->irq = irq; } } Konrad