From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754090AbdDKO2w (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Apr 2017 10:28:52 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:37433 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752537AbdDKO2u (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Apr 2017 10:28:50 -0400
Subject: Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <1491902071-17935-1-git-send-email-thierry.escande@collabora.com>
 <1491902071-17935-2-git-send-email-thierry.escande@collabora.com>
 <20170411140919.GC4388@kroah.com>
Cc: linux-kernel@vger.kernel.org
From: Thierry Escande <thierry.escande@collabora.com>
Message-ID: <c58eb125-db5d-0553-6ffe-a4697000f58c@collabora.com>
Date: Tue, 11 Apr 2017 16:28:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170411140919.GC4388@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg

On 11/04/2017 16:09, Greg Kroah-Hartman wrote:
> On Tue, Apr 11, 2017 at 11:14:30AM +0200, Thierry Escande wrote:
>> +#include <linux/export.h>
>> +
>> +#include "vpd_decode.h"
>> +
>> +static int decode_len(const int32_t max_len, const uint8_t *in,
>> +		      int32_t *length, int32_t *decoded_len)
>> +{
>> +	uint8_t more;
>
> Care to use "real" kernel variable types please?  u8, u16, and others
> are you friend, uint8_t really isn't what we prefer, and checkpatch
> should tell you that...

By default checkpatch doesn't warn about types unless --strict is 
specified... Sorry about that.

Regards,
  Thierry