From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5308A3207; Sun, 19 Jan 2025 16:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737304234; cv=none; b=C4qHrWe7mKHjj+H9/X06j0zlYUvjA7x5sEHkcsXaCZ8F5VPzI6JbFHAFc4Q3pnUSkV9C7SWRJkV7VMjH7din11sLlcViCNTym9AWv1eHRrvfloLJzkD9BSuTzd+LAFBxBtBVhe0HObNW0kY4mgXZB5hxg2rw0zgjxzaLK6QSpdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737304234; c=relaxed/simple; bh=pNA8pTGmyqesSb5RNq/Jqk3pe6bXGxZEBcn0j+R2euA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cc5uZturVrURz2aBoebyB1ZGenpB87jcZ4xNfAKxIakpV4kPSC+6KVMevIt7Jn6bs2/331E/d9SHtT46YdE1WcApRvewRGG5qfU9C6woeKIGOd4Xqn/bBIW6+iYo9eyNGnmrfyVYBZGduQFMEvXK8s0FnXjOjVNjcOTTV5riDCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=NDV8Pl+5; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NDV8Pl+5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=HwefpYHMifKM3JidAjIGjZi09phyptztxDCC5QWqai0=; b=ND V8Pl+5Bj0uqmEJ1/llB3+mur1d1FJ1ryhUol8M7vNx+0JxbtwQTP86VDOuaWZ2TI1cYkWuso0yHkM KCsolwe6lUvJrldGcKVKgFDalLuZWz3HVpV5VCy7r2GImKq9X8KHXaEgxAo02F0vetYxk383JzLwp R1HBdJddeUhTYeg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1tZYBo-0065O1-8N; Sun, 19 Jan 2025 17:30:20 +0100 Date: Sun, 19 Jan 2025 17:30:20 +0100 From: Andrew Lunn To: Dimitri Fedrau Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Niklas =?iso-8859-1?Q?S=F6derlund?= , Gregor Herburger , Stefan Eichenberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: phy: marvell-88q2xxx: Fix temperature measurement with reset-gpios Message-ID: References: <20250118-marvell-88q2xxx-fix-hwmon-v2-1-402e62ba2dcb@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250118-marvell-88q2xxx-fix-hwmon-v2-1-402e62ba2dcb@gmail.com> On Sat, Jan 18, 2025 at 07:43:43PM +0100, Dimitri Fedrau wrote: > When using temperature measurement on Marvell 88Q2XXX devices and the > reset-gpios property is set in DT, the device does a hardware reset when > interface is brought down and up again. That means that the content of > the register MDIO_MMD_PCS_MV_TEMP_SENSOR2 is reset to default and that > leads to permanent deactivation of the temperature measurement, because > activation is done in mv88q2xxx_probe. To fix this move activation of > temperature measurement to mv88q222x_config_init. > > Fixes: a557a92e6881 ("net: phy: marvell-88q2xxx: add support for temperature sensor") > Reviewed-by: Niklas Söderlund > Signed-off-by: Dimitri Fedrau Reviewed-by: Andrew Lunn Andrew