From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753078AbdJSLty (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 07:49:54 -0400
Received: from mout.web.de ([212.227.17.12]:57344 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751680AbdJSLtw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 07:49:52 -0400
Subject: Re: [PATCH 3/5] powerpc-pseries: Delete an unnecessary variable
 initialisation in iommu_pseries_alloc_group()
To: =?UTF-8?Q?Michal_Such=c3=a1nek?= <msuchanek@suse.de>,
        linuxppc-dev@lists.ozlabs.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
        Alexey Kardashevskiy <aik@ozlabs.ru>,
        Andrew Morton <akpm@linux-foundation.org>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        David Gibson <david@gibson.dropbear.id.au>,
        Doug Ledford <dledford@redhat.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nathan Fontenot <nfont@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>, Rob Herring <robh@kernel.org>,
        Sahil Mehta <sahilmehta17@gmail.com>,
        Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <0d221be4-1402-0499-d95e-afa4a30e1f33@users.sourceforge.net>
 <9c71e3e0-8998-fd02-e3a3-ef219d82ee32@users.sourceforge.net>
 <20171019133718.5bdab33c@kitsune.suse.cz>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c5905c07-6127-685d-98b0-5c2bbeabe5ea@users.sourceforge.net>
Date: Thu, 19 Oct 2017 13:49:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171019133718.5bdab33c@kitsune.suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:ZbmiQC8yJ/F9Uxh7wIbyHzkGMmwsp2fgCVOCvTeYilM5i6bNJc6
 9vo6HkQkfJkdSj7v5+fpwkyBP+Ab5DgwXYW6KPp4sGGWwNdtyK8Si81/s8Y8YyjWA2bRfro
 MDYNecgdJ/q4eqqRppEq6rb/017VR72CK9/i6LgfOL8tw5M0cm4bp3De5GMl++a4Si49/cP
 RDIDN6BN9Am4enV9BaFSA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:0AqcmJpjfp0=:VbXQRoagcgjx0ElasSFooD
 pUXpMIsdDp79EVHHwuh4rxAnVVRCrfK1YdIToNxMnuol880xDrXtmYomcFfPC5wOFjl/4bozc
 t30tahXQPyFofY3UBS0l+PL17qdr4bbUDINxZokAAHKohMQgDZpEjCVoW4UKREL7Wp3hOVAat
 ZmhaUtwGRCAvrSZNBKozc2Dhn1TmWioxrVrP8zyAzFfyQXKEj7Dv8HP/nzUNJlRJjqMD+XhB/
 jnptvUoIZbz/S52GJKPFJCYkeWir5HGjIa4ON44UhHpqnswj3dKGJ93VDnIj580ZknbHpzI+l
 AFdNvOCHrGza/emvo8Kx3Aia3XHMysEPmR/drUcQSyC8RWxLYVfGfvTvg3GZltN64pCsRZnAp
 IZHsmiChvySZzBDYNoygmHw1jpWiCH2sDQUDPhPjeAFqFbxtTqg/5q3oQJVmdwLip7+HstOIC
 cEz+GPTrkFVyx4jJ0/SDbdPnGH5wz0wjL4oa2WwZUnnkO/cpxN4p5+SJIpzXU0c5K4U1oG6qs
 K2apfDrmwMLB4CJo86hfVdKYTmaCfZUXRkptCSEFNGBL+zMKBRKK3d+OKQKy6Tubjr5EORlry
 AbAyOfL+eh8Z5GXCHSWs2jnrJn9/Djw/zYSjQf16YbOnhL3GpxZXwG8m22fXgNFf/wVzmxSQF
 pWQjuGud+REOQkYIzJ9IpGMZmwoe+Wp/J0hhBmfscmEF8xb5zPiOcyheG2Ttb6AzEsLpWyaPv
 k1+/nNl/1Yzny50ta9lr/4wmGKn/GfSAN94R/4PR2T9x7V4dPA93orS2BiermUwMoO+N7yy/d
 l0zjefVEwOCNrz7MAwrAmVnRRqLnlk7yiYs3AwonoTDVngy7Sw=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>  static struct iommu_table_group *iommu_pseries_alloc_group(int node)
>>  {
>> -	struct iommu_table_group *table_group = NULL;
>> +	struct iommu_table_group *table_group;
>>  	struct iommu_table *tbl = NULL;
>>  	struct iommu_table_group_link *tgl = NULL;
>>  
> 
> I think initializing pointers to NULL is generally a good idea.

This one would also not be needed if the call of the function “kzalloc_node”
could be specified in the same statement.


> Removing these initializers adds no value, to the contrary.

This small update step is just a “preparation” for the subsequent two suggestions
in this patch series.

Regards,
Markus