From: Mark Zhang <markzhang@nvidia.com>
To: cgel.zte@gmail.com, linux-kernel@vger.kernel.org
Cc: linux-rdma@vger.kernel.org, ye xingchen <ye.xingchen@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] IB/cm:Change the conditional statements
Date: Mon, 1 Aug 2022 10:41:59 +0800 [thread overview]
Message-ID: <c5968cf4-c63f-eb70-136b-cb002810f115@nvidia.com> (raw)
In-Reply-To: <20220801023146.1594841-1-ye.xingchen@zte.com.cn>
On 8/1/2022 10:31 AM, cgel.zte@gmail.com wrote:
> External email: Use caution opening links or attachments
>
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Conditional statements could changed to be easier explain.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/infiniband/core/cm.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index b985e0d9bc05..6e323d0c0fce 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -676,14 +676,9 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
> refcount_inc(&cm_id_priv->refcount);
> return cm_id_priv;
> }
> - if (device < cm_id_priv->id.device)
> + if (device < cm_id_priv->id.device ||
> + be64_lt(service_id, cm_id_priv->id.service_id))
> node = node->rb_left;
> - else if (device > cm_id_priv->id.device)
> - node = node->rb_right;
> - else if (be64_lt(service_id, cm_id_priv->id.service_id))
> - node = node->rb_left;
> - else if (be64_gt(service_id, cm_id_priv->id.service_id))
> - node = node->rb_right;
> else
> node = node->rb_right;
> }
> --
> 2.25.1
This is not correct, ref.:
https://lore.kernel.org/lkml/20220624201733.GA284068@nvidia.com/t/
prev parent reply other threads:[~2022-08-01 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 2:31 cgel.zte
2022-08-01 2:41 ` Mark Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5968cf4-c63f-eb70-136b-cb002810f115@nvidia.com \
--to=markzhang@nvidia.com \
--cc=cgel.zte@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®