From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mark Gross <mgross@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Moody Salem <moody@uniswap.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] ACPI / scan: Don't create platform device for INT3515 ACPI nodes
Date: Mon, 4 Jan 2021 14:59:28 +0100 [thread overview]
Message-ID: <c59bb4a0-62bc-3390-dd29-758d415c59fa@redhat.com> (raw)
In-Reply-To: <20210104122343.GT4077@smile.fi.intel.com>
Hi,
On 1/4/21 1:23 PM, Andy Shevchenko wrote:
> On Mon, Jan 04, 2021 at 12:59:39PM +0100, Hans de Goede wrote:
>> On 12/23/20 3:36 PM, Heikki Krogerus wrote:
>>> There are several reports about the tps6598x causing
>>> interrupt flood on boards with the INT3515 ACPI node, which
>>> then causes instability. There appears to be several
>>> problems with the interrupt. One problem is that the
>>> I2CSerialBus resources do not always map to the Interrupt
>>> resource with the same index, but that is not the only
>>> problem. We have not been able to come up with a solution
>>> for all the issues, and because of that disabling the device
>>> for now.
>>>
>>> The PD controller on these platforms is autonomous, and the
>>> purpose for the driver is primarily to supply status to the
>>> userspace, so this will not affect any functionality.
>>>
>>> Reported-by: Moody Salem <moody@uniswap.org>
>>> Fixes: a3dd034a1707 ("ACPI / scan: Create platform device for INT3515 ACPI nodes")
>>> Cc: stable@vger.kernel.org
>>> Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1883511
>>> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>
>> Thank you for your patch, I've applied this patch to my review-hans
>> branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>
>> Note it will show up in my review-hans branch once I've pushed my
>> local branch there, which might take a while.
>>
>> Once I've run some tests on this branch the patches there will be
>> added to the platform-drivers-x86/for-next branch and eventually
>> will be included in the pdx86 pull-request to Linus for the next
>> merge-window.
>
> I'm wondering if my reply has been seen...
>
> https://lore.kernel.org/platform-driver-x86/ae94a191-4273-0000-deda-4859034343b8@redhat.com/T/#m30308ca22cd0ce266aa6913ab7ef1fc56b3279de
Yes I've done the s/Link/BugLink/ in the commit msg and fixed up the
typo-s in the comment block locally. I should have mentioned that in
my reply instead of just blindly using the template-reply which I have for
this, sorry; and thank you for the review.
Regards,
Hans
next prev parent reply other threads:[~2021-01-04 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 14:36 Heikki Krogerus
2020-12-23 16:34 ` Andy Shevchenko
2021-01-04 11:59 ` Hans de Goede
2021-01-04 12:23 ` Andy Shevchenko
2021-01-04 13:59 ` Hans de Goede [this message]
2021-01-04 14:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59bb4a0-62bc-3390-dd29-758d415c59fa@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=moody@uniswap.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®