From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35666C4724C for ; Mon, 4 May 2020 16:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1090A206D9 for ; Mon, 4 May 2020 16:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729460AbgEDQFK (ORCPT ); Mon, 4 May 2020 12:05:10 -0400 Received: from www62.your-server.de ([213.133.104.62]:45066 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbgEDQFJ (ORCPT ); Mon, 4 May 2020 12:05:09 -0400 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jVdaZ-0004zi-1W; Mon, 04 May 2020 18:05:03 +0200 Received: from [178.195.186.98] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVdaY-000HF6-Hv; Mon, 04 May 2020 18:05:02 +0200 Subject: Re: [PATCH bpf 0/2] bpf, arm: Small JIT optimizations To: Luke Nelson , bpf@vger.kernel.org Cc: Luke Nelson , Shubham Bansal , Russell King , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200501020210.32294-1-luke.r.nels@gmail.com> From: Daniel Borkmann Message-ID: Date: Mon, 4 May 2020 18:05:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200501020210.32294-1-luke.r.nels@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25802/Mon May 4 14:12:31 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/1/20 4:02 AM, Luke Nelson wrote: > As Daniel suggested to us, we ran our formal verification tool, Serval, > over the arm JIT. The bugs we found have been patched and applied to the > bpf tree [1, 2]. This patch series introduces two small optimizations > that simplify the JIT and use fewer instructions. > > [1] https://lore.kernel.org/bpf/20200408181229.10909-1-luke.r.nels@gmail.com/ > [2] https://lore.kernel.org/bpf/20200409221752.28448-1-luke.r.nels@gmail.com/ > > Luke Nelson (2): > bpf, arm: Optimize emit_a32_arsh_r64 using conditional instruction > bpf, arm: Optimize ALU ARSH K using asr immediate instruction > > arch/arm/net/bpf_jit_32.c | 14 +++++++++----- > arch/arm/net/bpf_jit_32.h | 2 ++ > 2 files changed, 11 insertions(+), 5 deletions(-) > Applied, thanks!