From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB72C43461 for ; Mon, 14 Sep 2020 08:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC10521BE5 for ; Mon, 14 Sep 2020 08:45:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gnsy7hs0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726209AbgINIpN (ORCPT ); Mon, 14 Sep 2020 04:45:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:48949 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726078AbgINIpJ (ORCPT ); Mon, 14 Sep 2020 04:45:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600073106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pW/vk94WsYEDRmXNshGA+k0R8rAa7yyDn4jRtsj9CG8=; b=Gnsy7hs0q+6AOQ5RUetgcdaWsJuYS62nl5EgdHIfkAPC0PZtSW+kAg/IFMYrbUYtO8BiO7 YUlu6vf78mwjsZIt8cBbyHPSBKSCLTR2Nc70fuz+popE9hAdMRjf+k/5qJEmgt8jNTiEsO WpkcjhX7zPL6Z7fNp9NyUntTX3d5KRU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-kmbptXFkOcC5D8j4BaV5Ow-1; Mon, 14 Sep 2020 04:45:05 -0400 X-MC-Unique: kmbptXFkOcC5D8j4BaV5Ow-1 Received: by mail-ed1-f69.google.com with SMTP id m10so1016926edj.3 for ; Mon, 14 Sep 2020 01:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pW/vk94WsYEDRmXNshGA+k0R8rAa7yyDn4jRtsj9CG8=; b=QOkkzaCsgpRFj38cHAo0al1S6w+w2Jx0cT5bOIwiAduWgDsbeIZPTmf/q1KaCtT599 +V4JIr4ym1ScTYGrK7TUI+etaj53hLolWX4f3Ff8lpOP9n8z8EeIH3w097KHfq2NIPOd OX36d9o9ZyHWYA/ImJgG4tbrBMZ88yR9NZd3ULHi224TGl2KHEE4lYAeqGtz9kjG2UDG 1XH7hOYM+wLZZcW/uINtJ9fe2ibqPBIQs1YSMnTQbQNt9K9kzmVW95eAvhbb6+RgB26o dXEc4VYc5dl7EvnfcOSNUH62vk2LE790t/MIjqC6Vl5aucluokQgTgll3uoP9PoBjhEa xaLA== X-Gm-Message-State: AOAM532l6yZb9527Z6KCHTxx8J4uxthgIqreqjDqnuZqpgXXtpo4uJaa 58iH+CiUV6pS1agfKdvlUXSlvhS7ZaJI7jp1PDwee97BZjvR+mRug/SZa1XEgsn6LKkwKLsj1VM ITiGHp4F1O4WVlr6u0WFcNKjx X-Received: by 2002:a17:907:408d:: with SMTP id nt21mr13288573ejb.355.1600073103718; Mon, 14 Sep 2020 01:45:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqpFgAK/K/xz5l1UvFiBdC94iD63utdCj8DMpAFZ8VvVN87Ixvtwhq6KbisXo7mWn4AYgV+Q== X-Received: by 2002:a17:907:408d:: with SMTP id nt21mr13288561ejb.355.1600073103520; Mon, 14 Sep 2020 01:45:03 -0700 (PDT) Received: from x1.localdomain ([78.108.130.193]) by smtp.gmail.com with ESMTPSA id p17sm1537912edw.10.2020.09.14.01.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2020 01:45:02 -0700 (PDT) Subject: Re: [PATCH] Introduce support for Systems Management Driver over WMI for Dell Systems To: "Limonciello, Mario" , Divya Bharathi , "dvhart@infradead.org" Cc: LKML , "platform-driver-x86@vger.kernel.org" , "Bharathi, Divya" , "Ksr, Prasanth" References: <20200730143122.10237-1-divya_bharathi@dell.com> From: Hans de Goede Message-ID: Date: Mon, 14 Sep 2020 10:45:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Sorry for being slow with getting back to you on this. On 9/1/20 4:22 PM, Limonciello, Mario wrote: >> >> "A read-only attribute enumerating if a reboot is pending on any BIOS attribute >> change." >> does not really seem to make much sense. I guess what this is trying to say is: >> >> "This read-only attribute reads 1 if a reboot is necessary to apply pending BIOS >> attribute changes"? >> >> 0: All BIOS attributes setting are current >> 1: A reboot is necessary to get pending pending BIOS attribute >> changes applied >> >> Or some such. I'm not really happy with my own text either, but I think it >> better explains >> what this attribute is about then the original text, right ? > > I think that text does read better, Divya and team will reword it. > > > >>> + display_name_language_code: A file that can be read to obtain >>> + the language code corresponding to the "display_name" of the >> >> This needs to be specified better, e.g. this needs to say that this is an >> ISO 639‑1 language code (or some other language-code specification) > > Ack. > >> >> >>> + >>> + modifier: A file that can be read to obtain attribute-level >>> + dependency rule which has to be met to configure >> >> What is the difference between modifier and value_modifier ? Also this need to >> be specified in more detail. > > Ack. > >> >>> + >>> + possible_value: A file that can be read to obtain the possible >>> + value of the >> >> This is an enum, so possible value_s_ ? I assume that for a enum this will list >> all possible values, this also needs to specify how the possible values will be >> separated (e.g. using semi-colons or newlines or ...). > > Yes correct. > >> >> >>> + >>> + value_modifier: A file that can be read to obtain value-level >>> + dependency on a possible value which has to be met to configure >> >>> + >>> +What: /sys/devices/platform/dell-wmi- >> sysman/attributes/integer// >>> +Date: October 2020 >>> +KernelVersion: 5.9 >>> +Contact: Divya Bharathi , >>> + Mario Limonciello , >>> + Prasanth KSR >>> +Description: >>> + This directory exposes interfaces for interaction with >>> + BIOS integer attributes. >>> + >>> + Integer attributes are settings that accept a range of >>> + numerical values for inputs. Each BIOS integer has a >>> + lower bound and an upper bound on the values that it can take. >>> + >>> + current_value: A file that can be read to obtain the current >>> + value of the >>> + >>> + This file can also be written to in order to update >>> + the value of an . >>> + >>> + default_value: A file that can be read to obtain the default >>> + value of the >>> + >>> + display_name: A file that can be read to obtain a user friendly >>> + description of the at >>> + >>> + display_name_language_code: A file that can be read to obtain >>> + the language code corresponding to the "display_name" of the >>> + >>> + lower_bound: A file that can be read to obtain the lower >>> + bound value of the >>> + >>> + modifier: A file that can be read to obtain attribute-level >>> + dependency rule which has to be met to configure >>> + >>> + scalar_increment: A file that can be read to obtain the >>> + resolution of the incremental value this attribute accepts. >>> + >>> + upper_bound: A file that can be read to obtain the upper >>> + bound value of the >> >> Are these integers or also possibly floats? I guess possibly also floats, right? >> Then at a minimum this should specify which decimal-separator is used (I assume >> we will go with the usual '.' as decimal separator). > > In practice they're integers, but I don't see why they couldn't be floats. Hmm, that is a bit hand-wavy, for an userspace ABI we really need to define this clearly. Either it is integers (which is fine), or it is floats and we need to define a decimal-separator as part of the ABI. Note the reason why I started wondering about this in the first place is the scalar_increment attribute. I think that can use some clarification too. Regards, Hans