mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Salah Triki <salah.triki@acm.org>
To: akpm@linux-foundation.org, joe@perches.com
Cc: Salah Triki <salah.triki@acm.org>, linux-kernel@vger.kernel.org
Subject: [PATCH V3 3/4] fs: befs: Remove useless pr_err
Date: Thu, 26 May 2016 01:13:43 +0100	[thread overview]
Message-ID: <c5a7f2d42ec0fc8465c118248e88cd221c483391.1464221265.git.salah.triki@acm.org> (raw)
In-Reply-To: <ed41da113fc693c7daa4e8813ca04cc766ddfc05.1464221265.git.salah.triki@acm.org>
In-Reply-To: <d400aaf5a7430de79bd956e40ec075fb1cb08474.1464221265.git.salah.triki@acm.org>

Remove pr_err since when kzalloc fails there is a generic out of memory
and stack dump.

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 fs/befs/linuxvfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index edee857..5b47b0f 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -764,11 +764,9 @@ befs_fill_super(struct super_block *sb, void *data, int silent)
 	save_mount_options(sb, data);
 
 	sb->s_fs_info = kzalloc(sizeof(*befs_sb), GFP_KERNEL);
-	if (sb->s_fs_info == NULL) {
-		pr_err("(%s): Unable to allocate memory for private "
-		       "portion of superblock. Bailing.\n", sb->s_id);
+	if (sb->s_fs_info == NULL)
 		goto unacquire_none;
-	}
+
 	befs_sb = BEFS_SB(sb);
 
 	if (!parse_options((char *) data, &befs_sb->mount_opts)) {
-- 
1.9.1

  reply	other threads:[~2016-05-26  0:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26  0:13 [PATCH V3 1/4] fs: befs: Move useless assignment Salah Triki
2016-05-26  0:13 ` [PATCH V3 2/4] fs: befs: Check silent flag before logging errors Salah Triki
2016-05-26  0:13   ` Salah Triki [this message]
2016-05-26  0:13     ` [PATCH V3 4/4] fs: befs: Remove useless befs_error Salah Triki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5a7f2d42ec0fc8465c118248e88cd221c483391.1464221265.git.salah.triki@acm.org \
    --to=salah.triki@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®