mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Zhongjin <chenzhongjin@huawei.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: <alexander.sverdlin@nokia.com>, <ardb@kernel.org>,
	<linus.walleij@linaro.org>, <nico@fluxnic.net>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: module: Add all unwind tables when load module
Date: Thu, 31 Mar 2022 18:15:09 +0800	[thread overview]
Message-ID: <c5a918fd-5700-267d-3159-6a034cce0a73@huawei.com> (raw)
In-Reply-To: <YkVQXPYkae41B7Z2@shell.armlinux.org.uk>

Hi Russell,

Thanks for comment! I've pushed v2 patch with your advises.

>>   
>> -	memset(maps, 0, sizeof(maps));
>> +	INIT_LIST_HEAD(&table_list->mod_list);
>> +	mod->arch.init_table = NULL;
>>   
>>   	for (s = sechdrs; s < sechdrs_end; s++) {
>> -		const char *secname = secstrs + s->sh_name;
>> +		const unsigned int sectype = s->sh_type;
> Please loose this local variable.

Also I moved "txtname" inside func params.

+		const char *txtname = strcmp(".ARM.exidx", secname) == 0 ?
+				".text" : secname + strlen(".ARM.exidx");
+		const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs, txtname);

 >>>

+		const Elf_Shdr *txt_sec = find_mod_section(hdr, sechdrs,
+				strcmp(".ARM.exidx", secname) ?
+				secname + strlen(".ARM.exidx") : ".text");



  reply	other threads:[~2022-03-31 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25  1:12 Chen Zhongjin
2022-03-31  2:18 ` Chen Zhongjin
2022-03-31  6:55 ` Russell King (Oracle)
2022-03-31 10:15   ` Chen Zhongjin [this message]
2022-03-31 10:35     ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5a918fd-5700-267d-3159-6a034cce0a73@huawei.com \
    --to=chenzhongjin@huawei.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=ardb@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®