From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F7C1E505 for ; Fri, 30 Jan 2026 07:03:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769756639; cv=none; b=ac3lddYFd0m43iEE66u1vyVm/Q31Gg80kOKxwqtDfyP0555Tr4ljZdjLtFkdwDNKYK2MdZiBLz3TOYdEETkLCE9NQTpnwExbh2ZelggPACXMj2ItZD8/RBVmSQwuQ+v4+9r5HgK5bY3jE8dTwZk5S+TnBXE5RGxqGvUVIAca7yM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769756639; c=relaxed/simple; bh=85qwfsFCAztNi0YFiuPSb3IVyem+uphlWZ8XLNYAsuw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TQ5jpd+HAVSxH+CSBwyGfz08F1JZCUl8vyFSY4csTCcE0uNwKG1c0Tu6yVebYxmcgZXSpXneFz/iGZ9e6er1mV7KI8EVnVcn2puplyLsePcnZeqcD2noVAROsry0wImyI7KR1IIdTkSre5NorVtLwBh7CvI0uRhYGFOhPYLt4VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=If8ezSzl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RgjlAb8v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="If8ezSzl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RgjlAb8v" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60U4bL031485247 for ; Fri, 30 Jan 2026 07:03:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3F4T+IeKKJ2+B9uNR/SwtxkVQIyvpzTD34HVI9Mg+8s=; b=If8ezSzlfZA4SBBy rZU0Zyf63SlCcXV/tZky5ZbhwgQVPU+OypGPs/hLXnIUSJy42viYPwJvF9kwP7ua cay5Q+UMr1kfK/0Mwo0pa3cqSLd9VQw28GskSjQ/EcZ7UDdmiT/obsxO2cp5w3TQ 3TdRpvBABOC267++jwyiMhj42hnYWI67RNAn8kge6vQ6MhtZ+wUbFrxHIjBoErpx dBl88e/BrOEO/Rhk5LDqW2KMeG6+FwSN0FL9yDTuSdBVGMZhuLp8sjAxxG8L2DE0 Y0x5BVLfwEKCbNUo8FLHLS4fOJEQu53BoA8+RzGR9vCfTtp7/yMx3gcEX12rSWGX mKgFOg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0nsf8caj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 07:03:56 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a79164b686so19849205ad.0 for ; Thu, 29 Jan 2026 23:03:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769756636; x=1770361436; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3F4T+IeKKJ2+B9uNR/SwtxkVQIyvpzTD34HVI9Mg+8s=; b=RgjlAb8v4Z/ztYu06HkIWULAMajfFhyV6taU9n26Wgv9kUMob5EaDCD6suQdQFqT/d +BlwVHJeLjcQXvYCoLd3MpXWJcLNHcQMTS+UWvw/qLFcVMtUGWV0fJy26yKSI1L/Pq32 giPFMspCXXMYii5F6rKBwlbw2bRUVxrqsO1sZ+XTH7NtLG5mhCgvfEmku705AP/yk3Wn Nq89D2ifue/hmI+Le+rz1W+9Tj7WImQKm88Tjp+RYoy2V2H4O6jkTlrsnaBU9sTm49Nz rdkZsrtOeV9DHKP512cHm8nkjyR5tlh0vbDYRmcMNK6tXs4JS8rZl6pp7dGr1wPMhwdR mHHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769756636; x=1770361436; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3F4T+IeKKJ2+B9uNR/SwtxkVQIyvpzTD34HVI9Mg+8s=; b=Do5+N/xUctUgZONdc2uZnFo0ZOJSxH8+/m59QGm2wWzEJSGHSunQoDDdgz+BRAWKAP A0/1vTEx/ZFT5XbegtKgkF1UG7kImSoWrUkY7GKfusy+1JByt4/dKEwGf71qmyE2l29M 6dIKh6Dt6Evp4NQBDj6HAE2MsELU+0yCnhEHMYWrg7UmXnnxAHfxcZ9bN0qTEdfk34jl 36bkrSgbOJu/iOAEAmpRYCs26kFYOnfhh7kmq5CwpmcivmWeXBVJYTXjt361DDfCi08u ylm67c8zCEf+CwGwFg6yizl7C4Fuj3EDU6Fo4rwkxgNuOgT5lo6wpVjv/iJM1JXbwMdv Vz1w== X-Forwarded-Encrypted: i=1; AJvYcCXiQKETGje8uUhekWa3veUd2K4s49wXcieHQjSIFRF7vDNYzqJSYnPrsXBOBt4mLrYl4DeN7zShPB6mvrg=@vger.kernel.org X-Gm-Message-State: AOJu0YxipusjH4JI6clxrSLqVrQ5uUYVZOHnwXREQpspARZpDvf8Ei9G 7OPKb9GGPyp1/XhR6RaG1Wxjsfwm+cFdcYoU/iL0TJPZkrYlLYjoOW2LNjbQIbLOtEsj2WSPC/4 d3HB80kPPL7tMKlhJdePug7mERW8sYju5e8Nd/M9m4ZvE2TYbigj75Rdn6pTgrVisIfY= X-Gm-Gg: AZuq6aI5NA/hrHnlURon6KY2ovUw7fCkW/yfkTj+kxdSEiMpd9j/wgmM7lKwfQG3ogc Xa5OTjJFoj4GRFeBieapqHl5DyMel5lg1fjyXCCKNNznYLuDmbHp3MwPKigaVp/2L9jxwdyWS7F DDWoen+swliRJ6AhoDHzynHEsVeRP6gtHiDyBXEkPhkV4b2tNd42qzmmlybSUzHxfPhr5v7I0nY ptiQqFAtqy623t56n/duQ0i6W8AhHSpqEthKJZnI2FUcu96NmdVRS7cM8fiSxw9aEZo9O30NwfV FkzCZujRHiKI43S0sFOI6xjY98lVkhhXwrIaTZr7M7lkMD9qjwYoRP/aefYc9mjSdpcKTDraPYn bVoRIOP8iQesTEeyh2wGDvU/WbAer3xapCPOl+TGx X-Received: by 2002:a17:903:41cb:b0:2a3:1d78:7505 with SMTP id d9443c01a7336-2a8d9953170mr18327035ad.56.1769756635932; Thu, 29 Jan 2026 23:03:55 -0800 (PST) X-Received: by 2002:a17:903:41cb:b0:2a3:1d78:7505 with SMTP id d9443c01a7336-2a8d9953170mr18326515ad.56.1769756635144; Thu, 29 Jan 2026 23:03:55 -0800 (PST) Received: from [10.217.199.117] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b3eec76sm70715005ad.19.2026.01.29.23.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 23:03:54 -0800 (PST) Message-ID: Date: Fri, 30 Jan 2026 12:33:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] remoteproc: qcom: probe all child devices To: Konrad Dybcio , Dmitry Baryshkov Cc: Bjorn Andersson , mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, amitk@kernel.org, mani@kernel.org, casey.connolly@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20251223123227.1317244-1-gaurav.kohli@oss.qualcomm.com> <20251223123227.1317244-3-gaurav.kohli@oss.qualcomm.com> <57493aef-fb35-4377-8cf3-1df7f53470c9@oss.qualcomm.com> <74h7r3vsig3csejax3eu3uk53mdiimg2hjx7ntmmfrwdai6s3j@eiztghclfcvt> <5db5dafd-3c1f-4844-b822-bbfe86b3eb4d@oss.qualcomm.com> <98397a59-8ef2-4202-ae41-015c895d6bce@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: <98397a59-8ef2-4202-ae41-015c895d6bce@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: Mnb5YRT3pPxItC3_SoG2VJ4mwi14dAZi X-Authority-Analysis: v=2.4 cv=EvjfbCcA c=1 sm=1 tr=0 ts=697c57dc cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=j1b_eO6ZJhPIRq7GVskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: Mnb5YRT3pPxItC3_SoG2VJ4mwi14dAZi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA1MyBTYWx0ZWRfX3A+gGK+dwHg6 ni0jju524C+NihLbtsWCsmfY7TdiNgEa1bk/LnigPSDfmgxlbtzG1/Oz3NaFaPpVOw3KE3hVI6D mpoGgH1NzFK5iQkP+RbXlJUjNfCKTLvUw3B4AnwK3li5AV9Qy+TRcauB15OioRXZ89QvqlMEcl+ DZ+aH8QKpGGQZUHwAf1vYgZSngzWkQXmUSXI4CDHZG8R9Y7oR/+vX1XEhG7iWQyndmT812l8RaU qYOfa3EI81o4o0NUG2IHImq9GQTIkxrNadRPuhnXOfcSlFguUXHBOyf7df5lkElRUr66Zv+/D6V /ykKeKNpEZZqCno05soGITQ2/Y75KtgjVMaHBZ8SO1ZphIQbuvHxKDvqm8PdDQL2bc83eiEscj2 T1n8mx7Bxlt+dDcifbEnA3rBk9o5n7wA64isebN7hCeRDO24MlaC3AZtvLiPvvCclrG53dO8/CO IBdOmhM1gRVVmW3qCfQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300053 On 1/28/2026 3:15 PM, Konrad Dybcio wrote: > On 1/28/26 10:39 AM, Gaurav Kohli wrote: >> On 1/27/2026 10:11 PM, Dmitry Baryshkov wrote: >>> On Tue, Jan 27, 2026 at 09:42:10PM +0530, Gaurav Kohli wrote: >>>> On 1/24/2026 12:33 AM, Dmitry Baryshkov wrote: >>>>> On Fri, Jan 23, 2026 at 07:23:39PM +0530, Gaurav Kohli wrote: >>>>>> On 1/8/2026 12:37 PM, Gaurav Kohli wrote: >>>>>>> On 1/3/2026 8:26 PM, Bjorn Andersson wrote: >>>>>>>> On Tue, Dec 23, 2025 at 06:02:21PM +0530, Gaurav Kohli wrote: >>>>>>>>> From: Casey Connolly >>>>>>>>> >>>>>>>>> Generalise the qcom,bam-dmux child node support by probing all >>>>>>>>> remoteproc children with of_platform_populate(). This will be used to >>>>>>>>> enable support for devices which are best represented as >>>>>>>>> subnodes of the >>>>>>>>> remoteproc, such as those representing QMI clients. >>>>>>>> Please flip this around, start with the description of the problem >>>>>>>> you're trying to solve. >>>>>>>> >>>>>>>>> Signed-off-by: Casey Connolly >>>>>>>> This must have your signed-off-by, where you certifies the origin of >>>>>>>> this patch. >>>>>>>> >>>>>>>>> --- >>>>>>>>>     drivers/remoteproc/qcom_q6v5.c     | 4 ++++ >>>>>>>>>     drivers/remoteproc/qcom_q6v5_mss.c | 8 -------- >>>>>>>>>     2 files changed, 4 insertions(+), 8 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/drivers/remoteproc/qcom_q6v5.c >>>>>>>>> b/drivers/remoteproc/qcom_q6v5.c >>>>>>>>> index 58d5b85e58cd..a02839c7ed8c 100644 >>>>>>>>> --- a/drivers/remoteproc/qcom_q6v5.c >>>>>>>>> +++ b/drivers/remoteproc/qcom_q6v5.c >>>>>>>>> @@ -6,6 +6,7 @@ >>>>>>>>>      * Copyright (C) 2014 Sony Mobile Communications AB >>>>>>>>>      * Copyright (c) 2012-2013, The Linux Foundation. All rights >>>>>>>>> reserved. >>>>>>>>>      */ >>>>>>>>> +#include >>>>>>>>>     #include >>>>>>>>>     #include >>>>>>>>>     #include >>>>>>>>> @@ -351,6 +352,8 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, >>>>>>>>> struct platform_device *pdev, >>>>>>>>>             return dev_err_probe(&pdev->dev, PTR_ERR(q6v5->path), >>>>>>>>>                          "failed to acquire interconnect path\n"); >>>>>>>>>     +    of_platform_populate(q6v5->dev->of_node, NULL, NULL, q6v5->dev); >>>>>>>> There are other child nodes here, in particular the GLINK and SMD edges. >>>>>>>> Do we really want platform_devices registered for them? >>>>>>>> >>>>>>>> Regards, >>>>>>>> Bjorn >>>>>>> thanks for pointing this, can you please suggest the right approach. >>>>>>> >>>>>>> This should not impact glink, as that is registering as rproc sub node, >>>>>>> And we need rproc cooling as child node >>>>>>> >>>>>>> of remote proc subsytem to create probe dependency only. >>>>>>> >>>>>>> >>>>>>> Can we do platform populate for specific child, would that be right >>>>>>> approach. or we should create rproc cooling as independent of parent ? >>>>>>> >>>>>> HI Bjorn, >>>>>> >>>>>> I’d like to highlight the impact and details of placement of remoteproc >>>>>> cooling dt node: >>>>>> >>>>>> >>>>>> ->As a child of the remote proc subsystem node: >>>>>>       In this configuration, the cooling device will only be probed once the >>>>>> corresponding remote proc subsystem itself is probed. >>>>>> >>>>>> ->Outside the remote proc subsystem, may be part of soc node: >>>>>>       In this setup, the cooling device will be probed independently. It will >>>>>> wait until the remoteproc subsystem is brought up >>>>>>       before completing cooling registration. >>>>>>       The drawback here is that if the parent remoteproc subsystem is >>>>>> disabled, the cooling device will still undergo an >>>>>>       unnecessary probe, even though it cannot be registered. >>>>> Bjorns question was different. It wasn't about pushing cooling device >>>>> outside of the remoteproc node. It is about not registering the devices. >>>>> >>>>> Can we follow the approach outlined by qcom_add_smd_subdev() / >>>>> qcom_add_glink_subdev()? >>>> Hi Dmitry, >>>> >>>> Thanks for the review. Since the remoteproc cooling is a QMI-based driver, >>>> it will receive the >>>> subsystem up notification directly. Therefore, there’s no need to make it a >>>> subdev node or >>>> tie it into the init/reset sequence of remoteproc subsytem. >>> But you've added a subnode for it (and we are discussing exactly >>> of_platform_populate()) call. So, you are tying it to the remoteproc >>> device lifecycle instead of the remoteproc subsys, which seems strange >>> to me. There is no cooling device if the DSP is not running. >> >> For the cooling feature, we don’t need to define it as a subnode. The cooling subsystem becomes relevant only >> after the remote subsystem is up, at which point it will receive add/delete notifications from the QMI server. >> >> >> If child nodes must be modeled as subnodes for rproc, we can move the CDSP TMD out of the remoteproc and add in soc. >> Is there currently a way for the remoteproc core layer to call of_platform_populate() without requiring a subnode? > I think the question is "why can't you register the remoteproc device > as a cooling_device, with perhaps #cooling-cells = <1>; instead of > any form of children?" > > Konrad thanks Konrad, for the review. As each subsystem can expose multiple thermal mitigation devices via the remoteproc TMD service, so need to define child node.