From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755219AbcHSBV7 (ORCPT ); Thu, 18 Aug 2016 21:21:59 -0400 Received: from foss.arm.com ([217.140.101.70]:33192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbcHSBVn (ORCPT ); Thu, 18 Aug 2016 21:21:43 -0400 Subject: Re: [PATCH 01/13] scpi: Add vendor_send_message to enable access to vendor commands To: Neil Armstrong , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1471515066-3626-1-git-send-email-narmstrong@baylibre.com> <1471515066-3626-2-git-send-email-narmstrong@baylibre.com> Cc: Sudeep Holla , linux-amlogic@lists.infradead.org, khilman@baylibre.com, heiko@sntech.de, wxt@rock-chips.com, frank.wang@rock-chips.com From: Sudeep Holla Organization: ARM Message-ID: Date: Thu, 18 Aug 2016 16:53:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471515066-3626-2-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/08/16 11:10, Neil Armstrong wrote: > Adds an optional vendor_send_message to the scpi to enable sending > vendor platform specific commands to the SCP firmware. > I don't see any users of vendor_send_message in this series, so I prefer it to be dropped and introduced when required. Also I had a different view on how to introduce this[1]. I would rather wait until the requirement comes that enables us to make use of it. Looks like you took parts of it and introduces vendor_send_message allowing users to send any data which I don't like especially without knowing how will it be (ab)used. -- Regards, Sudeep [1] http://www.spinics.net/lists/kernel/msg2263649.html