From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AE9A3793BF for ; Tue, 19 May 2026 07:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779176077; cv=none; b=gVPf1tIkQ5Y8HwcRJhJxZt5bcFw717Qah6xilmE/5smNpOQz3CjNgY8/zKgdUPkIkvMxwibTV2cb/5Hc9vihNzPP0cETkpMwQGN+dhPIXnZK9aEkUe86BaomlfC8x3iVmxzzc31oVhTWbNMxboMAgKrjHgmHPbyKbIBXdQMxxUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779176077; c=relaxed/simple; bh=WNsUAwkfsSDvKW1NR+1S0Le70HYoYNlJ0GV1NMIckdQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=AY0ze36bXYN+wr2MzB8jbClN/41x9fB/9IJGNE5iWVq7zMLTFe589V3deQ3SJwGhhBKC5J+7akcVOC7dMmyIl5C+wEBAf5sI+ILGWCFc/p4XgWAg+8j5Zy6a2D7Y7FITiSzlaNookweDmdvvaHXesxndSzanp7XW75AvCsN7SL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gxjfPJ92; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gxjfPJ92" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so47082985e9.2 for ; Tue, 19 May 2026 00:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779176074; x=1779780874; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=NkpJii8tv30gQeyVix9/XICxyBov61uU4hi0wKikcJ8=; b=gxjfPJ92KAz8AG4sBsa6LC6oTiebmW1Ksb05vPuAm0UHNG94TGbipII861I2EAT1Gp Z189vld+brN25FTD0bPyzlpseUZPgdLj0KB2RWTlEjRF/11Zjes/i8uroE/CqWn16iBU TEVtCgBJVy7Tk/SJgXiSGD3fMOUZHSeJAY9boL8MK67+HzSPuiLcb835Dq7zfb1x5TP+ BSt1POM4CtjyooPeuj73Y6yWs6JnSvb10wDFDyU+VV5DjB3srnTTeFCgWJhjBOpI8AJf PYMnCBjR1xpSZqgnDhesf7yJv2E9LzeykAIHTHkTzQUI9LoLJ8vZf58LEgec9Nj+HfJw syvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779176074; x=1779780874; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NkpJii8tv30gQeyVix9/XICxyBov61uU4hi0wKikcJ8=; b=VM7Pzze/KK8g4GSUN6HMoDL8/mCc2EKajvEH0hiPg2nxqNsCBoM9p0UF22HOatZvav iOGJ5xxCk3d3Mi8A4ZRZtX0VG9384vrz3hs5DR7EbL1/A/ncitK8VYc1/cQglw+9nY6p QZkC/XT+EMTBjE8DJgtRRV2IwzHi9+hHSLGe1Grh5jfoRne1yPviP92XnEhndoiw9ywR OrvaH1nJOpDGxKNEgP/C4PLfcwoPCpOXze57PtyFvJ8OZQIijavPmlg6NXqhdYd23q4j LiicaPgPCa8jcUPSe/u7V7LHqtxGvpCFkqfHPTocH71zA7W/tOGtQH9okmXU7Jh1TKcp iQ8g== X-Forwarded-Encrypted: i=1; AFNElJ9bbCnpbzx6TbzPQj5/UERYXKW52g57LMLNG0NL/LtajdWIyIoZSkUDHd+Okwx6iEWA/X3LlzpUI9k3No4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7D4E11rK09D0VKCqWb7Ly0me2Zn+KagZjjh9Mhq2qLGgI3cpu YdaqJkUt4A7t+vq07bIs692RNVeLbsiNRyKHgmgfNpT/941QS9NyI0UfeQeHYqork1A= X-Gm-Gg: Acq92OEqFg5iSokUWEBo4bP+My+blubt/MLbvAu70pZ8p393otWPSsPWGjDiw4sHoB6 kFJHnzsNyzUUJzeL1aR89fhDKV7immv9NAm6dLAFdQVv20WTs/LvhpJ68BQX0avjMDHVZ/Uj+Lo j99MRJXMgy4R7P7nS05GGmN86VUUxIQBahtZ7rFwhbtMGXjZ+99uuhuyYatEyKO6RRwg6VY5xvA J3RYhN6Pd8nH5AARYGf8xhgOW99syQGfFBmF63jLvyfar3IUj86uVD/KEdIPSrq/X6Q/a4m7XGj 2rnj33SAHFqbw52dRUHDmf+Jvl7Kc4xwrIp43mZq7UP04Rnr1bIFzHbPEYUgc2KtHMfPzN5X3dC qxCs+P0MrKW/aYRmz34h2ULfiRBCGBSUyAXIYD3Cn+YivFxl4Lamu4x5B2SAH0DlSqLVH30d+TW awDfukkcj0NWGcSVYZOxIW+X9X9rcE1aWwNCuInJ93gGoBamP6nYJtazfn1im4y9ksIwgQ9MHcQ MK3FECNTXhGNxU= X-Received: by 2002:a05:600c:4692:b0:485:4eaf:eb53 with SMTP id 5b1f17b1804b1-48fe632661bmr293018735e9.19.1779176074203; Tue, 19 May 2026 00:34:34 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0a17a22sm43795418f8f.22.2026.05.19.00.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:34:33 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 09:34:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 10/13] drm/meson: dw-hdmi: Use dev_err_probe() to report errors To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-11-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-11-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/18/26 21:47, Jonas Karlman wrote: > Change to use dev_err_probe() to report bind() errors consistently. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 65 +++++++++++++-------------- > 1 file changed, 30 insertions(+), 35 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index d0cf2042d41c..1dd59196ff7f 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -650,10 +650,9 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > DRM_DEBUG_DRIVER("\n"); > > match = of_device_get_match_data(dev); > - if (!match) { > - dev_err(dev, "failed to get match data\n"); > - return -ENODEV; > - } > + if (!match) > + return dev_err_probe(dev, -ENODEV, > + "Failed to get match data\n"); > > meson_dw_hdmi = devm_kzalloc(dev, sizeof(*meson_dw_hdmi), > GFP_KERNEL); > @@ -667,50 +666,45 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > > ret = devm_regulator_get_enable_optional(dev, "hdmi"); > if (ret < 0 && ret != -ENODEV) > - return ret; > + return dev_err_probe(dev, ret, > + "Failed to get/enable hdmi regulator\n"); > > meson_dw_hdmi->hdmitx_apb = devm_reset_control_get_exclusive(dev, > "hdmitx_apb"); > - if (IS_ERR(meson_dw_hdmi->hdmitx_apb)) { > - dev_err(dev, "Failed to get hdmitx_apb reset\n"); > - return PTR_ERR(meson_dw_hdmi->hdmitx_apb); > - } > + if (IS_ERR(meson_dw_hdmi->hdmitx_apb)) > + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmitx_apb), > + "Failed to get hdmitx_apb reset\n"); > > meson_dw_hdmi->hdmitx_ctrl = devm_reset_control_get_exclusive(dev, > "hdmitx"); > - if (IS_ERR(meson_dw_hdmi->hdmitx_ctrl)) { > - dev_err(dev, "Failed to get hdmitx reset\n"); > - return PTR_ERR(meson_dw_hdmi->hdmitx_ctrl); > - } > + if (IS_ERR(meson_dw_hdmi->hdmitx_ctrl)) > + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmitx_ctrl), > + "Failed to get hdmitx reset\n"); > > meson_dw_hdmi->hdmitx_phy = devm_reset_control_get_exclusive(dev, > "hdmitx_phy"); > - if (IS_ERR(meson_dw_hdmi->hdmitx_phy)) { > - dev_err(dev, "Failed to get hdmitx_phy reset\n"); > - return PTR_ERR(meson_dw_hdmi->hdmitx_phy); > - } > + if (IS_ERR(meson_dw_hdmi->hdmitx_phy)) > + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmitx_phy), > + "Failed to get hdmitx_phy reset\n"); > > meson_dw_hdmi->hdmitx = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(meson_dw_hdmi->hdmitx)) > return PTR_ERR(meson_dw_hdmi->hdmitx); > > clk = devm_clk_get_enabled(dev, "isfr"); > - if (IS_ERR(clk)) { > - dev_err(dev, "Unable to get isfr pclk\n"); > - return PTR_ERR(clk); > - } > + if (IS_ERR(clk)) > + return dev_err_probe(dev, PTR_ERR(clk), > + "Failed to get isfr pclk\n"); > > clk = devm_clk_get_enabled(dev, "iahb"); > - if (IS_ERR(clk)) { > - dev_err(dev, "Unable to get iahb pclk\n"); > - return PTR_ERR(clk); > - } > + if (IS_ERR(clk)) > + return dev_err_probe(dev, PTR_ERR(clk), > + "Failed to get iahb pclk\n"); > > clk = devm_clk_get_enabled(dev, "venci"); > - if (IS_ERR(clk)) { > - dev_err(dev, "Unable to get venci pclk\n"); > - return PTR_ERR(clk); > - } > + if (IS_ERR(clk)) > + return dev_err_probe(dev, PTR_ERR(clk), > + "Failed to get venci pclk\n"); > > dw_plat_data->regm = devm_regmap_init(dev, NULL, meson_dw_hdmi, > &meson_dw_hdmi_regmap_config); > @@ -724,10 +718,9 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq, > dw_hdmi_top_thread_irq, IRQF_SHARED, > "dw_hdmi_top_irq", meson_dw_hdmi); > - if (ret) { > - dev_err(dev, "Failed to request hdmi top irq\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, > + "Failed to request hdmi top irq\n"); > > meson_dw_hdmi_init(meson_dw_hdmi); > > @@ -752,14 +745,16 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > meson_dw_hdmi->hdmi = dw_hdmi_probe(pdev, &meson_dw_hdmi->dw_plat_data); > if (IS_ERR(meson_dw_hdmi->hdmi)) { > devm_free_irq(dev, irq, meson_dw_hdmi); > - return PTR_ERR(meson_dw_hdmi->hdmi); > + return dev_err_probe(dev, PTR_ERR(meson_dw_hdmi->hdmi), > + "Failed to probe dw-hdmi bridge\n"); > } > > meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(dev->of_node); > if (!meson_dw_hdmi->bridge) { > devm_free_irq(dev, irq, meson_dw_hdmi); > dw_hdmi_remove(meson_dw_hdmi->hdmi); > - return -ENODEV; > + return dev_err_probe(dev, -ENODEV, > + "Failed to find dw-hdmi bridge\n"); > } > > DRM_DEBUG_DRIVER("HDMI controller initialized\n"); Reviewed-by: Neil Armstrong Thanks, Neil