From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260F9C28CBC for ; Wed, 6 May 2020 12:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04451206DD for ; Wed, 6 May 2020 12:07:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbgEFMHh (ORCPT ); Wed, 6 May 2020 08:07:37 -0400 Received: from foss.arm.com ([217.140.110.172]:35076 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727976AbgEFMHh (ORCPT ); Wed, 6 May 2020 08:07:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 291481FB; Wed, 6 May 2020 05:07:36 -0700 (PDT) Received: from [10.57.31.214] (unknown [10.57.31.214]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA1EF3F71F; Wed, 6 May 2020 05:07:32 -0700 (PDT) Subject: Re: [PATCH v2 2/2] Documentation/vmcoreinfo: Add documentation for 'KERNELPACMASK' To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Bhupesh Sharma , Vincenzo Frascino , James Morse , Mark Rutland , Dave Young , Baoquan He References: <1587968702-19996-1-git-send-email-amit.kachhap@arm.com> <1587968702-19996-2-git-send-email-amit.kachhap@arm.com> <20200504173440.GE1833@willie-the-truck> From: Amit Kachhap Message-ID: Date: Wed, 6 May 2020 17:37:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20200504173440.GE1833@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/4/20 11:04 PM, Will Deacon wrote: > On Mon, Apr 27, 2020 at 11:55:02AM +0530, Amit Daniel Kachhap wrote: >> Add documentation for KERNELPACMASK variable being added to the vmcoreinfo. >> >> It indicates the PAC bits mask information of signed kernel pointers if >> Armv8.3-A Pointer Authentication feature is present. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Mark Rutland >> Cc: Dave Young >> Cc: Baoquan He >> Signed-off-by: Amit Daniel Kachhap >> --- >> Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> index 007a6b8..5cc3ee6 100644 >> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst >> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst >> @@ -393,6 +393,12 @@ KERNELOFFSET >> The kernel randomization offset. Used to compute the page offset. If >> KASLR is disabled, this value is zero. >> >> +KERNELPACMASK >> +------------- >> + >> +Indicates the PAC bits mask information if Pointer Authentication is >> +enabled and address authentication feature is present. > > This is a bit cryptic. How about: > > The mask to extract the Pointer Authentication Code from a kernel virtual > address. Ok sure. I will update like this in the v3 version. Cheers, Amit Daniel > > Will >