From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5EA9315B6; Sun, 17 Dec 2023 18:14:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Q6Uixddx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=H3Yg9Ks44h9xKxHznRP1HbmjN2e0OY+H92vAnJ0cCh0=; b=Q6UixddxCDy7gVGAHV27qsheGf Jd7EFu86koHVAIv7bZFLthsnvAftOIxQh4UtTzhOfPcsqmAZ+TZNvXGBGr2GrrMk3fK7jIl6QWyVA Ld+EoMuLG3+RXOg5ZWFFtSKxh1GqGoldy526reoKJMgBgZ6EORoh31GgUVM0b542unKU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rEvel-003AIp-Ax; Sun, 17 Dec 2023 19:14:27 +0100 Date: Sun, 17 Dec 2023 19:14:27 +0100 From: Andrew Lunn To: Stefan Wahren Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/12 net-next] qca_spi: Improve SPI IRQ handling Message-ID: References: <20231214150944.55808-1-wahrenst@gmx.net> <20231214150944.55808-3-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214150944.55808-3-wahrenst@gmx.net> On Thu, Dec 14, 2023 at 04:09:34PM +0100, Stefan Wahren wrote: > The functions qcaspi_netdev_open/close are responsible of request & > free of the SPI interrupt, which wasn't the best choice because > allocation problems are discovered not during probe. So let us split > IRQ allocation & enabling, so we can take advantage of a device > managed IRQ. Could you replace the kernel thread with a threaded interrupt handler? Andrew