From: Tero Kristo <t-kristo@ti.com>
To: Stephen Boyd <sboyd@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver
Date: Thu, 22 Jun 2017 09:09:09 +0300 [thread overview]
Message-ID: <c5b9e51f-4c16-6cdd-0b84-dd372d1e7982@ti.com> (raw)
In-Reply-To: <20170621215053.GH4493@codeaurora.org>
On 22/06/17 00:50, Stephen Boyd wrote:
> On 06/20, Arnd Bergmann wrote:
>> CONFIG_COMPILE_TEST allows building a configuration without
>> TI_SCI_PROTOCOL, which then fails to link:
>>
>> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
>> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
>>
>> This makes it a hard dependency. Right now, that means we can't
>> actually compile-test the driver unless ARCH_KEYSTONE is set as
>> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
>> be selected for COMPILE_TEST as well.
>>
>> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>
> Looks ok to me. Tero?
>
Yeah, looks okay to me also, been traveling so sorry about the latency.
Acked-by: Tero Kristo <t-kristo@ti.com>
next prev parent reply other threads:[~2017-06-22 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 20:12 Arnd Bergmann
2017-06-21 21:50 ` Stephen Boyd
2017-06-22 6:09 ` Tero Kristo [this message]
2017-06-23 0:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b9e51f-4c16-6cdd-0b84-dd372d1e7982@ti.com \
--to=t-kristo@ti.com \
--cc=arnd@arndb.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®