From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EDCEEB64DD for ; Wed, 28 Jun 2023 19:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbjF1TkZ (ORCPT ); Wed, 28 Jun 2023 15:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231561AbjF1TkW (ORCPT ); Wed, 28 Jun 2023 15:40:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEE5010FB; Wed, 28 Jun 2023 12:40:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4550D61460; Wed, 28 Jun 2023 19:40:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54110C433C0; Wed, 28 Jun 2023 19:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687981220; bh=klgTWdJWuY+ukpWOnYTdmCpH06zL7nTICvdJceCsqqQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CylwdhInikX6hCGDUJn+nYbTRlGsBpp8Ur1zy7oz6vC3UiprJVxVbFkCZu74t2Jtu ZiEy79TUuvXOOtW/Bfd3qpZLlyZFkU5s41sV/eC5HbLQ4zcrdDAc553OUbwklCuyRg na5DZ7Re+mqsLV37CoA4VTFyrlL+fDLinK29qUx22ceiiKxmgtjSevvnmNaaTt033Z IZ6IL22GqPzZqCgBJwJNQIkU5ToE4Sn5FwqVysax+mF/tePaX3LFWpfdteoqyMR4sL CQh/pCdpvXIZy2UcIY+I6iVRPEcJ3LbQTaqJDECGNaFtJN9fzCErqCO1FIg8cNB48P llGyLkXmA2NiA== Date: Wed, 28 Jun 2023 20:40:12 +0100 From: Mark Brown To: Dmitry Baryshkov Cc: Srinivas Kandagatla , krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, johan+linaro@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: Re: [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT Message-ID: References: <20230628102621.15016-1-srinivas.kandagatla@linaro.org> <20230628102621.15016-3-srinivas.kandagatla@linaro.org> <73dce263-bee6-554f-9eb6-af4aa7badab1@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mgpSf2rFHH6HbzH9" Content-Disposition: inline In-Reply-To: X-Cookie: HELLO, everybody, I'm a HUMAN!! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mgpSf2rFHH6HbzH9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 28, 2023 at 10:33:16PM +0300, Dmitry Baryshkov wrote: > On 28/06/2023 21:10, Mark Brown wrote: > > If the goal here is to put all the firmwares for a given board in a > > single place surely it would be better to factor this all out of the > > individual drivers so that they ask some helper for a directory to use > > for firmware? Adding these device specific firmware node properties > > doesn't seem to follow. > This quickly becomes overcomplicated. Some platforms use different firmware > naming structure. Some firmware goes into a generic location and other files > go into device-specific location. So having a generic helper doesn't really > help. That sounds like a job for symlinks surely? --mgpSf2rFHH6HbzH9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmScjJwACgkQJNaLcl1U h9BCDgf+MwHq6JhItt1dx5AosYopofv5eM+cXQTZJxH7Ty1pBE0ZrubrQITHgUps ZMN5jdtiLpD1sam4qsyb1yNUB8o+4sk7p6Q6rKS/Bwv73R6lQwd04PS3+KW+12V/ Pg39ZUdB4XjjKgmKQ+LKBXZi2qkB4Vhd9ApqIMIEtNYXhRk68JVnhlUseenPfn6Y +bay/mh1nmisb1hVYEhwlabisc2pRStjRhD4+MKBxEEdHPKyUtUciYCUasW4OCj6 mcptRKGax8OZWyWykw0htaHI19V+6QkTFvZDlNc7mwWBqQx+t7FxgsbpGR3Eo1L2 dnMNFETQ1pxu67LvWHYP5e6gRpok4Q== =Nl3r -----END PGP SIGNATURE----- --mgpSf2rFHH6HbzH9--