From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A39EC26A08A for ; Thu, 24 Jul 2025 10:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354471; cv=none; b=dQ5rdUgBPWBb9IBDi7lDz7PTndthOz2WQJBngwipSUg6IYuv1IFe+LDXXBj/YSprfyHNqt57RleoB+Hq/sEsgNo84F++4EYr8NzwlUdL3SLpk1cSHY09zljF+AxhqVz283+jlWcHEtqkTeKHmqiJrDcQfoTALsnjxwNwVTl8mS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354471; c=relaxed/simple; bh=/mUnW+P6NksHTbmrvTOZRabCk9vs0OY5vRp8VFVko+8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kEIuxN7njbVsVYI5Hz87hTTj5W51MDIvnH5/BkrYJxqbYHaUz8Mzkky6m5b6uHWoQtsCoDlvC1M+bl4oItWiPO+1p6/TM1vZ7PJF89UsA98hhXAp8/KbDzE43X3TSRR8wALbaGaMbyFYGsJ79wvSzM3EohxeE7oj/SkyOfNvGJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=yTWcuJZ1; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=A6Q+Ll3r; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=yTWcuJZ1; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=A6Q+Ll3r; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="yTWcuJZ1"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="A6Q+Ll3r"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="yTWcuJZ1"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="A6Q+Ll3r" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C98E51F770; Thu, 24 Jul 2025 10:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1753354466; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MnTbb83fMEQqePlK+8z7J40I1jbxEB517acwflv6VHs=; b=yTWcuJZ1Liz6+HI7hdohJZmVzuYMnOU+BNueP3Ay+K+gopXRiPW8stID6x+1hTGYDtqt/z l94bdOnD25KSe6FSkrqYceTZcdOuMMtbu/Rte9MyGL46DcdawvmyHs0C61glgFOMgkuAPU FkGOH+R2O2BSHEiPlb1mhX//wm0s8T4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1753354466; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MnTbb83fMEQqePlK+8z7J40I1jbxEB517acwflv6VHs=; b=A6Q+Ll3rRKvQ20Qot9B2rLxjhuBMp7Es+T8ENhFR7gQOoUCkXbpOf/4zXdAx/k8CKAAkAj FmAMiOw/Bsq4F8Dw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1753354466; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MnTbb83fMEQqePlK+8z7J40I1jbxEB517acwflv6VHs=; b=yTWcuJZ1Liz6+HI7hdohJZmVzuYMnOU+BNueP3Ay+K+gopXRiPW8stID6x+1hTGYDtqt/z l94bdOnD25KSe6FSkrqYceTZcdOuMMtbu/Rte9MyGL46DcdawvmyHs0C61glgFOMgkuAPU FkGOH+R2O2BSHEiPlb1mhX//wm0s8T4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1753354466; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MnTbb83fMEQqePlK+8z7J40I1jbxEB517acwflv6VHs=; b=A6Q+Ll3rRKvQ20Qot9B2rLxjhuBMp7Es+T8ENhFR7gQOoUCkXbpOf/4zXdAx/k8CKAAkAj FmAMiOw/Bsq4F8Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEDFE136DC; Thu, 24 Jul 2025 10:54:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nj0UKuIQgmh2bgAAD6G6ig (envelope-from ); Thu, 24 Jul 2025 10:54:26 +0000 Message-ID: Date: Thu, 24 Jul 2025 12:54:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs Content-Language: en-US From: Vlastimil Babka To: John Hubbard , Lorenzo Stoakes , Jason Gunthorpe Cc: David Hildenbrand , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Mike Rapoport , Suren Baghdasaryan , Peter Xu References: <1a7513cf-4a0a-4e58-b20d-31c1370b760f@lucifer.local> <72bb36f2-65b6-4785-af9d-5b1f8126fc78@lucifer.local> <2f866f12-2aa0-4456-b215-08ddc9b13b1e@redhat.com> <3dfbbd63-697d-42aa-8906-539d74df9123@nvidia.com> <44af8f5a-2d94-498b-a3e0-31f5dde74538@redhat.com> <20250606184212.GB63308@ziepe.ca> <20250607134214.GA158671@ziepe.ca> <04f52d21-baeb-4286-99eb-99edead514b8@lucifer.local> <8ce6c104-d2fb-4fed-a108-224a6113c227@nvidia.com> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[] X-Spam-Flag: NO X-Spam-Level: X-Spam-Score: -4.30 On 6/9/25 11:57, Vlastimil Babka wrote: > On 6/7/25 8:00 PM, John Hubbard wrote: >> On 6/7/25 6:53 AM, Lorenzo Stoakes wrote: >> The worst part is that if you go to reproduce a problem, you don't >> see the next warning in the logs!! This is devastating, especially if >> the site makes it hard to ask for a system reboot. (If you have >> ~20,000 nodes in the cluster, a reboot is not a small affair.) > > Assuming you know how to reproduce the problem... I wonder if it would > help if there was a way (sysctl?) to re-arm all the _ONCE warnings. It > shouldn't be that hard hopefully? Oh hey it already exists, since 2017 echo 1 > /sys/kernel/debug/clear_warn_once