From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753090AbcEIR1y (ORCPT ); Mon, 9 May 2016 13:27:54 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35910 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752617AbcEIR1w (ORCPT ); Mon, 9 May 2016 13:27:52 -0400 Subject: Re: [PATCH] mm: slab: remove ZONE_DMA_FLAG To: Michal Hocko References: <1462381297-11009-1-git-send-email-yang.shi@linaro.org> <20160505114946.GI4386@dhcp22.suse.cz> Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org From: "Shi, Yang" Message-ID: Date: Mon, 9 May 2016 10:27:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160505114946.GI4386@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/2016 4:49 AM, Michal Hocko wrote: > On Wed 04-05-16 10:01:37, Yang Shi wrote: >> Now we have IS_ENABLED helper to check if a Kconfig option is enabled or not, >> so ZONE_DMA_FLAG sounds no longer useful. >> >> And, the use of ZONE_DMA_FLAG in slab looks pointless according to the >> comment [1] from Johannes Weiner, so remove them and ORing passed in flags with >> the cache gfp flags has been done in kmem_getpages(). >> >> [1] https://lkml.org/lkml/2014/9/25/553 > > I haven't checked the patch but I have a formal suggestion. > lkml.org tends to break and forget, please use > http://lkml.kernel.org/r/$msg-id instead. In this case > http://lkml.kernel.org/r/20140925185047.GA21089@cmpxchg.org Thanks for the suggestion. Will use msg-id in later post. Regards, Yang > > Thanks! >