From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kconfig: fix broken dependency in randconfig-generated .config
Date: Fri, 7 Feb 2020 10:41:33 +0000 [thread overview]
Message-ID: <c5c1a416-5e90-edf6-8f35-93776f7a1d1b@arm.com> (raw)
In-Reply-To: <CAK7LNATTZGrJmh0CsR8eJUo3b13T9sjZPV4dh+2fCSZ9F4U0YA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1850 bytes --]
On 01/02/2020 05:11, Masahiro Yamada wrote:
> On Sat, Feb 1, 2020 at 2:03 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>
>> Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5)
>> produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y,
>> which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.
>>
>> This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs
>> CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the
>> value of CONFIG_EFI is calculated.
>>
>> When this happens, the has_changed flag should be set.
>>
>> Currently, it takes the result from the last iteration. It should
>> accumulate all the results of the loop.
>>
>> Reported-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>> ---
>
> Maybe, this could be tagged:
>
> Fixes: 3b9a19e08960 ("kconfig: loop as long as we changed some symbols
> in randconfig")
>
>
>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>
>
>> scripts/kconfig/confdata.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
>> index 99f2418baa6c..eb1efa3abdee 100644
>> --- a/scripts/kconfig/confdata.c
>> +++ b/scripts/kconfig/confdata.c
>> @@ -1353,7 +1353,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)
>>
>> sym_calc_value(csym);
>> if (mode == def_random)
>> - has_changed = randomize_choice_values(csym);
>> + has_changed |= randomize_choice_values(csym);
>> else {
>> set_all_choice_values(csym);
>> has_changed = true;
>> --
>> 2.17.1
>>
>
>
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
prev parent reply other threads:[~2020-02-07 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 5:03 Masahiro Yamada
2020-02-01 5:11 ` Masahiro Yamada
2020-02-07 10:41 ` Vincenzo Frascino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c1a416-5e90-edf6-8f35-93776f7a1d1b@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®