From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Matt Helsley <mhelsley@vmware.com>, linux-kernel@vger.kernel.org
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Julien Thierry <jthierry@redhat.com>
Subject: Re: [PATCH 2/2] objtool: Add support for relocations without addends
Date: Tue, 2 Jun 2020 21:42:38 +0530 [thread overview]
Message-ID: <c5cba21c-843e-9b42-010f-59cd31627ac3@linux.vnet.ibm.com> (raw)
In-Reply-To: <af8b5d5bffc64af00ad88e0b7bd216e91cbfdb36.1590785960.git.mhelsley@vmware.com>
On 5/30/20 2:31 AM, Matt Helsley wrote:
> Currently objtool only collects information about relocations with
> addends. In recordmcount, which we are about to merge into objtool,
> some supported architectures do not use rela relocations.
>
> Signed-off-by: Matt Helsley <mhelsley@vmware.com>
> ---
LGTM, minor nit-pick, checkpatch reports of missing space before '(' in
the switch cases. With space issues resolved:
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
Kamalesh
prev parent reply other threads:[~2020-06-02 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 21:01 [PATCH 0/2] objtool: Support implicit addend relocations Matt Helsley
2020-05-29 21:01 ` [PATCH 1/2] objtool: Rename rela to reloc Matt Helsley
2020-05-29 23:22 ` Josh Poimboeuf
2020-05-30 0:52 ` Matt Helsley
2020-06-01 15:09 ` Josh Poimboeuf
2020-05-29 21:01 ` [PATCH 2/2] objtool: Add support for relocations without addends Matt Helsley
2020-06-02 7:36 ` Julien Thierry
2020-06-02 16:12 ` Kamalesh Babulal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5cba21c-843e-9b42-010f-59cd31627ac3@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhelsley@vmware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome