From: Randy Dunlap <rdunlap@infradead.org>
To: Aksh Garg <a-garg7@ti.com>,
linux-pci@vger.kernel.org, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
bhelgaas@google.com, mpillai@cadence.com, 18255117159@163.com,
unicorn_wang@outlook.com
Cc: linux-kernel@vger.kernel.org, s-vadapalli@ti.com, danishanwar@ti.com
Subject: Re: [PATCH] PCI: cadence-plat: Fix host/endpoint dependencies
Date: Wed, 5 Aug 2026 10:29:33 -0700 [thread overview]
Message-ID: <c5cde08d-237f-4030-8fda-734489ce4333@infradead.org> (raw)
In-Reply-To: <20260805105014.3952686-1-a-garg7@ti.com>
On 8/5/26 3:50 AM, Aksh Garg wrote:
> The cadence-plat driver has a single platform driver that can be built-in
> or a loadable module, but it calls two separate backend drivers depending
> on whether it is a host or endpoint.
>
> If one of the mode is build as built-in and another as loadable module,
> we end up with a situation where the built-in pcie-cadence-plat driver
> tries to call the modular host or endpoint driver, which causes a link
> failure:
>
> ld: error: undefined symbol: cdns_pcie_ep_setup
> >>> referenced by pcie-cadence-plat.c
> >>> drivers/pci/controller/cadence/pcie-cadence-plat.o:(cdns_plat_pcie_probe) in archive vmlinux.a
>
> ld: error: undefined symbol: cdns_pcie_host_setup
> >>> referenced by pcie-cadence-plat.c
> >>> drivers/pci/controller/cadence/pcie-cadence-plat.o:(cdns_plat_pcie_probe) in archive vmlinux.a
>
> Fix this by moving the 'select' of PCIE_CADENCE_HOST and PCIE_CADENCE_EP
> from the individual PLAT_HOST/PLAT_EP symbols into the common PCIE_CADENCE_PLAT
> symbol, conditioned on which backends (modes) are enabled.
>
> Fixes: 611627a4e5e4 ("PCI: cadence: Add module support for platform controller driver")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/linux-next/589ea512-93c6-4e1c-83d7-ba45a0b35843@infradead.org/
> Signed-off-by: Aksh Garg <a-garg7@ti.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/pci/controller/cadence/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig
> index 9e651d545973..fd704dec47dd 100644
> --- a/drivers/pci/controller/cadence/Kconfig
> +++ b/drivers/pci/controller/cadence/Kconfig
> @@ -20,11 +20,12 @@ config PCIE_CADENCE_EP
>
> config PCIE_CADENCE_PLAT
> tristate
> + select PCIE_CADENCE_HOST if PCIE_CADENCE_PLAT_HOST != n
> + select PCIE_CADENCE_EP if PCIE_CADENCE_PLAT_EP != n
>
> config PCIE_CADENCE_PLAT_HOST
> tristate "Cadence platform PCIe controller (host mode)"
> depends on OF
> - select PCIE_CADENCE_HOST
> select PCIE_CADENCE_PLAT
> help
> Say Y here if you want to support the Cadence PCIe platform controller in
> @@ -35,7 +36,6 @@ config PCIE_CADENCE_PLAT_EP
> tristate "Cadence platform PCIe controller (endpoint mode)"
> depends on OF
> depends on PCI_ENDPOINT
> - select PCIE_CADENCE_EP
> select PCIE_CADENCE_PLAT
> help
> Say Y here if you want to support the Cadence PCIe platform controller in
--
~Randy
next prev parent reply other threads:[~2026-08-05 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 10:50 Aksh Garg
2026-08-05 17:29 ` Randy Dunlap [this message]
2026-08-06 16:47 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5cde08d-237f-4030-8fda-734489ce4333@infradead.org \
--to=rdunlap@infradead.org \
--cc=18255117159@163.com \
--cc=a-garg7@ti.com \
--cc=bhelgaas@google.com \
--cc=danishanwar@ti.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mpillai@cadence.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®